Remove redis from api dependencies #3326
Conversation
pkg/app/server/grpcapi/web_api.go
Outdated
| pipedStatCache cache.Cache | ||
| insightCache cache.Cache | ||
| redis redis.Redis | ||
| unregisteredAppStore unregisteredappstore.Store |
There was a problem hiding this comment.
nits, should move this to the upper block (nearby other stores) for better readable code 👍 (same with the piped_api.go PipedApi struct)
|
@Hosshii I think you need to run |
Co-authored-by: knanao <[email protected]>
Co-authored-by: knanao <[email protected]>
|
The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by You can check the build log from here. |
pkg/model/BUILD.bazel
Outdated
| "deployment.go", | ||
| "deployment_chain.go", | ||
| "docs.go", | ||
| "environment.pb.go", |
There was a problem hiding this comment.
Please remove this since it is no longer needed.
(I think you have to delete it at your local as well.)
|
Code coverage for golang is
|
|
Thank you for reviewing. |
|
Nice. Keep up your great work! |
|
Nice improvement 👍 |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
What this PR does / why we need it:
Remove redis from web_api and piped_api dependency.
Which issue(s) this PR fixes:
Fixes #2865
Does this PR introduce a user-facing change?: