Output artifact versions for ecs deployment #3385
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Code coverage for golang is
|
khanhtc1202
reviewed
Mar 10, 2022
| td, _ := parseTaskDefinition(tc.input) | ||
| versions, err := FindArtifactVersions(td) | ||
| assert.Equal(t, tc.expectedErr, err != nil) | ||
| assert.Equal(t, tc.expected, versions) |
Member
There was a problem hiding this comment.
Suggested change
| assert.Equal(t, tc.expected, versions) | |
| assert.ElementsMatch(t, tc.expected, versions) |
should use this to avoid order of results while checking
khanhtc1202
reviewed
Mar 10, 2022
| }, | ||
| } | ||
|
|
||
| for _, tc := range testcases { |
Member
There was a problem hiding this comment.
Suggested change
| for _, tc := range testcases { | |
| for _, tc := range testcases { | |
| tc := tc |
khanhtc1202
reviewed
Mar 10, 2022
| } | ||
| } | ||
|
|
||
| func TestFindArtifactVersions(t *testing.T) { |
Member
There was a problem hiding this comment.
Suggested change
| func TestFindArtifactVersions(t *testing.T) { | |
| func TestFindArtifactVersions(t *testing.T) { | |
| t.Parallel() | |
Collaborator
|
Code coverage for golang is
|
Member
|
Great work. |
ffjlabo
force-pushed
the
introduce_artifact_version_for_ecs
branch
from
674e335 to
4b32472
Compare
Collaborator
|
Code coverage for golang is
|
Member
|
Nice catch |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
This was referenced Mar 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR changes to output artifact versions for ecs development.
Which issue(s) this PR fixes:
A part of #3303
Does this PR introduce a user-facing change?: