Fix wrong GitHub actions configuration #3369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knanao
reviewed
Mar 9, 2022
| - uses: actions/setup-go@v2 | ||
| with: | ||
| go-version: '1.17.6' | ||
| - run: GOOS=linux GOARCH=amd64 go build -o artifacts/pipecd ./cmd/pipecd |
Member
There was a problem hiding this comment.
I think it better which we create make command and call that command from CI.
However we've already used build for bazel, that's why, it's up to you whether replace it or not.
Member
Author
There was a problem hiding this comment.
Totally agree about that.
I will refactor it later once confirmed that it works for our case.
Collaborator
|
Code coverage for golang is |
Member
|
Nice |
Member
|
Thanks |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
Collaborator
|
failed to handle template rule examples Details |
This was referenced Mar 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: