Move frontend code to the root directory #3376
Conversation
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
The Kapetanios build to run docker operations for the following 1. dockers/codegen - successAn image named codegen:0.6.0-85bcd57 was procuded for reviewing and testing. There is no test to run inside this directory. |
web/model/deployment_pb.js
Outdated
| var jspb = require('google-protobuf'); | ||
| var goog = jspb; | ||
| var global = (function() { | ||
| var global = (function () { |
There was a problem hiding this comment.
could you run yarn lint:fix to recheck this kind of indent 👀 Sorry if you already did 🙏
There was a problem hiding this comment.
Those files are generated code so let me fix them in another PR.
This PR should only be for the renaming of the directory.
There was a problem hiding this comment.
Ah I got your point. Not sure why it was modified. Let me regenerate the code.
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
The Kapetanios build to run docker operations for the following 1. dockers/codegen - successAn image named codegen:0.6.0-e96528c was procuded for reviewing and testing. There is no test to run inside this directory. |
|
A Kapetanios build has just been triggered to run docker operations for the following
|
|
Failed while validating Kapetanios configuration. Details |
|
The Kapetanios build to run docker operations for the following 1. dockers/codegen - successAn image named codegen:0.6.0-34f28ee was procuded for reviewing and testing. There is no test to run inside this directory. |
|
go bold |
|
Nice catch! Thank you. |
|
Allright. |
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
|
Thank you. |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: