Skip to content

Conversation

@nghialv
Copy link
Member

@nghialv nghialv commented Feb 22, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@knanao
Copy link
Member

knanao commented Feb 22, 2022

Nice catch!
/lgtm

@khanhtc1202
Copy link
Member

🤖

@khanhtc1202
Copy link
Member

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.53%. This pull request decreases coverage by -0.01%.

File Function Base Head Diff
pkg/app/piped/logpersister/stagelogpersister.go stageLogPersister.flushFromLastCheckpoint 61.11% 50.00% -11.11%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants