Add proto message for better running version of applicaion #3307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nghialv
reviewed
Feb 22, 2022
| DeploymentTrigger trigger = 2 [(validate.rules).message.required = true]; | ||
| string summary = 3; | ||
| string version = 4; | ||
| string config_filename = 5; |
Member
There was a problem hiding this comment.
The index number must be kept in order to avoid breaking change.
It means that with this change, the old Piped can not talk with the new server which is running with the new data layout.
nghialv
reviewed
Feb 22, 2022
pkg/model/application.proto
Outdated
Comment on lines
92
to
96
| message ApplicationComponentVersion { | ||
| ApplicationComponentKind kind = 1; | ||
| stirng version = 2; | ||
| string url = 3; | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| message ApplicationComponentVersion { | |
| ApplicationComponentKind kind = 1; | |
| stirng version = 2; | |
| string url = 3; | |
| } | |
| message ArtifactVersion { | |
| enum Kind { | |
| UNKNOWN = 0; | |
| CONTAINER_IMAGE = 1; | |
| } | |
| Kind kind = 1 [(validate.rules).enum.defined_only = true]; | |
| string version = 2 [(validate.rules).string.min_len = 1]; | |
| string name = 3; | |
| string url = 4; | |
| } |
Collaborator
|
Code coverage for golang is
|
Collaborator
|
Code coverage for javascript is
|
Member
|
Nice. Thank you. |
Member
Member
Author
|
ok, I fixed it! |
Member
|
Nice added 👍 |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
This was referenced Mar 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add proto message for better running version of applicaion
Which issue(s) this PR fixes:
A part of #3303
Does this PR introduce a user-facing change?: