-
Notifications
You must be signed in to change notification settings - Fork 204
Implement create interface for filedb database #3322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Code coverage for golang is
|
|
Good job. |
|
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use Details1. Find a way to generate function to build this kind of object by specifying a field tag in the proto file.pipecd/pkg/datastore/applicationstore.go Lines 66 to 69 in fa5d61a
This was created by todo plugin since "TODO:" was found in fa5d61a when #3322 was merged. cc: @khanhtc1202. |
|
Code coverage for golang is
|
|
Nice catch! |
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: