Skip to content

Conversation

@khanhtc1202
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

DOCKER

Unabled to get changed files of pull request.

Details
Error: rpc error: code = NotFound desc = not found

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.39%. This pull request decreases coverage by -0.19%.

File Function Base Head Diff
pkg/datastore/apikey.go apiKeyCollection.Encode -- 0.00% +0.00%
pkg/datastore/applicationstore.go applicationCollection.Encode -- 0.00% +0.00%
pkg/datastore/commandstore.go commandCollection.Encode -- 0.00% +0.00%
pkg/datastore/deploymentchainstore.go deploymentChainCollection.Encode -- 0.00% +0.00%
pkg/datastore/deploymentstore.go deploymentCollection.Encode -- 0.00% +0.00%
pkg/datastore/eventstore.go eventCollection.Encode -- 0.00% +0.00%
pkg/datastore/filedb/codec.go encode -- 0.00% +0.00%
pkg/datastore/pipedstore.go pipedCollection.Encode -- 0.00% +0.00%
pkg/datastore/projectstore.go projectCollection.Encode -- 0.00% +0.00%
pkg/datastore/filedb/filedb.go FileDB.Create 0.00% 0.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Feb 28, 2022

Good job.
/lgtm

@pipecd-bot pipecd-bot removed the lgtm label Feb 28, 2022
@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Find a way to generate function to build this kind of object by specifying a field tag in the proto file.

// TODO: Find a way to generate function to build this kind of object by specifying a field tag in the proto file.
// For example:
// ```proto
// message Application {

This was created by todo plugin since "TODO:" was found in fa5d61a when #3322 was merged. cc: @khanhtc1202.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 32.39%. This pull request decreases coverage by -0.19%.

File Function Base Head Diff
pkg/datastore/apikey.go apiKeyCollection.Encode -- 0.00% +0.00%
pkg/datastore/applicationstore.go applicationCollection.Encode -- 0.00% +0.00%
pkg/datastore/commandstore.go commandCollection.Encode -- 0.00% +0.00%
pkg/datastore/deploymentchainstore.go deploymentChainCollection.Encode -- 0.00% +0.00%
pkg/datastore/deploymentstore.go deploymentCollection.Encode -- 0.00% +0.00%
pkg/datastore/eventstore.go eventCollection.Encode -- 0.00% +0.00%
pkg/datastore/filedb/codec.go encode -- 0.00% +0.00%
pkg/datastore/pipedstore.go pipedCollection.Encode -- 0.00% +0.00%
pkg/datastore/projectstore.go projectCollection.Encode -- 0.00% +0.00%
pkg/datastore/filedb/filedb.go FileDB.Create 0.00% 0.00% +0.00%

@knanao
Copy link
Member

knanao commented Mar 1, 2022

Nice catch!
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by knanao.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants