Add ArtifactVersion to KubernetesApp Deployment #3340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Code coverage for golang is
|
nghialv
reviewed
Mar 4, 2022
| in.Logger.Error("unable to determine versions", zap.Error(e)) | ||
| out.Versions = []*model.ArtifactVersion{ | ||
| { | ||
| Kind: model.ArtifactVersion_CONTAINER_IMAGE, |
Member
There was a problem hiding this comment.
nit: We can use this kind
pipecd/pkg/model/application.proto
Line 90 in 0c6a1b3
nghialv
reviewed
Mar 4, 2022
Comment on lines
496
to
497
| // determineVersions decide artifact versions of an application. | ||
| // For example, in case some containers are used in one application, those image version are retured |
Member
There was a problem hiding this comment.
Suggested change
| // determineVersions decide artifact versions of an application. | |
| // For example, in case some containers are used in one application, those image version are retured | |
| // determineVersions decides artifact versions of an application. | |
| // It finds all container images that are being specified in the workload manifests then returns their names, version numbers, and urls. |
nghialv
reviewed
Mar 4, 2022
Comment on lines
501
to
521
| for _, m := range manifests { | ||
| if !m.Key.IsDeployment() { | ||
| continue | ||
| } | ||
| data, err := m.MarshalJSON() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| var d resource.Deployment | ||
| if err := json.Unmarshal(data, &d); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| containers := d.Spec.Template.Spec.Containers | ||
| for _, c := range containers { | ||
| image := parseContainerImage(c.Image) | ||
| versions = append(versions, &model.ArtifactVersion{ | ||
| Kind: model.ArtifactVersion_CONTAINER_IMAGE, | ||
| Version: image.tag, | ||
| Name: image.name, | ||
| Url: c.Image, | ||
| }) | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
Same container images could be used in multiple manifests so I think we have to remove the duplicate ones.
Member
|
@ffjlabo Great work! Love to see this. I have just left some comments. Please check them. |
khanhtc1202
reviewed
Mar 4, 2022
pkg/model/deployment.proto
Outdated
Comment on lines
151
to
161
| message ArtifactVersion { | ||
| enum Kind { | ||
| UNKNOWN = 0; | ||
| CONTAINER_IMAGE = 1; | ||
| } | ||
|
|
||
| Kind kind = 1 [(validate.rules).enum.defined_only = true]; | ||
| string version = 2 [(validate.rules).string.min_len = 1]; | ||
| string name = 3; | ||
| string url = 4; | ||
| } |
Member
There was a problem hiding this comment.
if we use it in both application and deployment proto, should we move it to common.proto?
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/app/piped/planner/kubernetes/kubernetes.go--- pkg/app/piped/planner/kubernetes/kubernetes.go.orig
+++ pkg/app/piped/planner/kubernetes/kubernetes.go
@@ -519,7 +519,7 @@
}
}
- for i, _ := range imageMap {
+ for i := range imageMap {
image := parseContainerImage(i)
versions = append(versions, &model.ArtifactVersion{
Kind: model.ArtifactVersion_CONTAINER_IMAGE,
|
pipecd-bot
reviewed
Mar 4, 2022
Collaborator
pipecd-bot
left a comment
pipecd-bot
left a comment
There was a problem hiding this comment.
Some issues were detected while linting go source files in your changes.
| } | ||
| } | ||
|
|
||
| for i, _ := range imageMap { |
Collaborator
There was a problem hiding this comment.
should omit 2nd value from range; this loop is equivalent to for i := range ...
Suggested change
| for i, _ := range imageMap { | |
| for i := range imageMap { |
Member
Author
|
/golinter fmt |
Collaborator
|
Unabled to format the unfmt-ed files. In response to this comment. |
nghialv
reviewed
Mar 4, 2022
pkg/model/application.proto
Outdated
| string version = 4; | ||
| string config_filename = 5; | ||
| repeated ArtifactVersion versions = 6; | ||
| repeated model.ArtifactVersion versions = 6; |
Member
There was a problem hiding this comment.
Suggested change
| repeated model.ArtifactVersion versions = 6; | |
| repeated ArtifactVersion versions = 6; |
nghialv
reviewed
Mar 4, 2022
| // It finds all container images that are being specified in the workload manifests then returns their names, version numbers, and urls. | ||
| func determineVersions(manifests []provider.Manifest) ([]*model.ArtifactVersion, error) { | ||
| versions := []*model.ArtifactVersion{} | ||
| imageMap := map[string]string{} |
Member
There was a problem hiding this comment.
To have smaller size.
Suggested change
| imageMap := map[string]string{} | |
| imageMap := map[string]struct{}{} |
nghialv
reviewed
Mar 4, 2022
| containers := d.Spec.Template.Spec.Containers | ||
| // remove duplicate images on multiple manifests | ||
| for _, c := range containers { | ||
| imageMap[c.Image] = "" |
Member
There was a problem hiding this comment.
Suggested change
| imageMap[c.Image] = "" | |
| imageMap[c.Image] = struct{} |
nghialv
reviewed
Mar 4, 2022
nghialv
reviewed
Mar 4, 2022
Comment on lines
532
to
539
| if len(versions) == 0 { | ||
| return []*model.ArtifactVersion{ | ||
| { | ||
| Kind: model.ArtifactVersion_UNKNOWN, | ||
| Version: versionUnknown, | ||
| }, | ||
| }, nil | ||
| } |
Member
There was a problem hiding this comment.
We don't need this part. An empty list is fine. It means that this application is not having any artifact version.
Collaborator
|
Code coverage for golang is
|
Collaborator
|
Code coverage for javascript is
|
ffjlabo
force-pushed
the
add_artifact_versions_to_deployment
branch
from
9fbbd4e to
0930876
Compare
Collaborator
|
Code coverage for golang is
|
nghialv
reviewed
Mar 4, 2022
pkg/model/deployment.proto
Outdated
| // e.g. Update image from v1.5.0 to v1.6.0. | ||
| string summary = 22; | ||
| string version = 23; | ||
| repeated ArtifactVersion versions = 103; |
Member
There was a problem hiding this comment.
Suggested change
| repeated ArtifactVersion versions = 103; | |
| repeated ArtifactVersion versions = 24; |
nghialv
reviewed
Mar 4, 2022
Comment on lines
499
to
522
| versions := []*model.ArtifactVersion{} | ||
| imageMap := map[string]struct{}{} | ||
|
|
||
| for _, m := range manifests { | ||
| // TODO: Determine container image version from other workload kinds such as StatefulSet, Pod, Daemon, CronJob... | ||
| if !m.Key.IsDeployment() { | ||
| continue | ||
| } | ||
| data, err := m.MarshalJSON() | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| var d resource.Deployment | ||
| if err := json.Unmarshal(data, &d); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| containers := d.Spec.Template.Spec.Containers | ||
| // remove duplicate images on multiple manifests | ||
| for _, c := range containers { | ||
| imageMap[c.Image] = struct{}{} | ||
| } | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Move initialization versions slice to later to know its size.
Suggested change
| versions := []*model.ArtifactVersion{} | |
| imageMap := map[string]struct{}{} | |
| for _, m := range manifests { | |
| // TODO: Determine container image version from other workload kinds such as StatefulSet, Pod, Daemon, CronJob... | |
| if !m.Key.IsDeployment() { | |
| continue | |
| } | |
| data, err := m.MarshalJSON() | |
| if err != nil { | |
| return nil, err | |
| } | |
| var d resource.Deployment | |
| if err := json.Unmarshal(data, &d); err != nil { | |
| return nil, err | |
| } | |
| containers := d.Spec.Template.Spec.Containers | |
| // remove duplicate images on multiple manifests | |
| for _, c := range containers { | |
| imageMap[c.Image] = struct{}{} | |
| } | |
| } | |
| imageMap := map[string]struct{}{} | |
| for _, m := range manifests { | |
| // TODO: Determine container image version from other workload kinds such as StatefulSet, Pod, Daemon, CronJob... | |
| if !m.Key.IsDeployment() { | |
| continue | |
| } | |
| data, err := m.MarshalJSON() | |
| if err != nil { | |
| return nil, err | |
| } | |
| var d resource.Deployment | |
| if err := json.Unmarshal(data, &d); err != nil { | |
| return nil, err | |
| } | |
| containers := d.Spec.Template.Spec.Containers | |
| // remove duplicate images on multiple manifests | |
| for _, c := range containers { | |
| imageMap[c.Image] = struct{}{} | |
| } | |
| } | |
| versions := make([]*model.ArtifactVersion, 0, len(imageMap)) |
Member
Author
There was a problem hiding this comment.
thank you for suggestion!
Collaborator
|
Code coverage for javascript is
|
Member
|
Look beautiful. |
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/app/helloworld/service/service_grpc.pb.go--- pkg/app/helloworld/service/service_grpc.pb.go.orig
+++ pkg/app/helloworld/service/service_grpc.pb.go
@@ -4,6 +4,7 @@
import (
context "context"
+
grpc "google.golang.org/grpc"
codes "google.golang.org/grpc/codes"
status "google.golang.org/grpc/status"
pkg/app/server/service/pipedservice/service_grpc.pb.go--- pkg/app/server/service/pipedservice/service_grpc.pb.go.orig
+++ pkg/app/server/service/pipedservice/service_grpc.pb.go
@@ -4,6 +4,7 @@
import (
context "context"
+
grpc "google.golang.org/grpc"
codes "google.golang.org/grpc/codes"
status "google.golang.org/grpc/status"
pkg/model/apikey.pb.go--- pkg/model/apikey.pb.go.orig
+++ pkg/model/apikey.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/common.pb.go--- pkg/model/common.pb.go.orig
+++ pkg/model/common.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/notificationevent.pb.go--- pkg/model/notificationevent.pb.go.orig
+++ pkg/model/notificationevent.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/piped_stat.pb.go--- pkg/model/piped_stat.pb.go.orig
+++ pkg/model/piped_stat.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/user.pb.go--- pkg/model/user.pb.go.orig
+++ pkg/model/user.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/app/server/service/apiservice/service_grpc.pb.go--- pkg/app/server/service/apiservice/service_grpc.pb.go.orig
+++ pkg/app/server/service/apiservice/service_grpc.pb.go
@@ -4,6 +4,7 @@
import (
context "context"
+
grpc "google.golang.org/grpc"
codes "google.golang.org/grpc/codes"
status "google.golang.org/grpc/status"
pkg/model/application.pb.go--- pkg/model/application.pb.go.orig
+++ pkg/model/application.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/command.pb.go--- pkg/model/command.pb.go.orig
+++ pkg/model/command.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/planpreview.pb.go--- pkg/model/planpreview.pb.go.orig
+++ pkg/model/planpreview.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/logblock.pb.go--- pkg/model/logblock.pb.go.orig
+++ pkg/model/logblock.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/app/server/service/apiservice/service.pb.go--- pkg/app/server/service/apiservice/service.pb.go.orig
+++ pkg/app/server/service/apiservice/service.pb.go
@@ -21,12 +21,14 @@
package apiservice
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
- model "github.com/pipe-cd/pipecd/pkg/model"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
+
+ model "github.com/pipe-cd/pipecd/pkg/model"
)
const (
pkg/app/server/service/pipedservice/service.pb.go--- pkg/app/server/service/pipedservice/service.pb.go.orig
+++ pkg/app/server/service/pipedservice/service.pb.go
@@ -21,12 +21,14 @@
package pipedservice
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
- model "github.com/pipe-cd/pipecd/pkg/model"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
+
+ model "github.com/pipe-cd/pipecd/pkg/model"
)
const (
pkg/app/server/service/webservice/service.pb.go--- pkg/app/server/service/webservice/service.pb.go.orig
+++ pkg/app/server/service/webservice/service.pb.go
@@ -21,13 +21,15 @@
package webservice
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
- model "github.com/pipe-cd/pipecd/pkg/model"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
wrapperspb "google.golang.org/protobuf/types/known/wrapperspb"
- reflect "reflect"
- sync "sync"
+
+ model "github.com/pipe-cd/pipecd/pkg/model"
)
const (
pkg/app/server/service/webservice/service_grpc.pb.go--- pkg/app/server/service/webservice/service_grpc.pb.go.orig
+++ pkg/app/server/service/webservice/service_grpc.pb.go
@@ -4,6 +4,7 @@
import (
context "context"
+
grpc "google.golang.org/grpc"
codes "google.golang.org/grpc/codes"
status "google.golang.org/grpc/status"
pkg/model/analysis_result.pb.go--- pkg/model/analysis_result.pb.go.orig
+++ pkg/model/analysis_result.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/deployment.pb.go--- pkg/model/deployment.pb.go.orig
+++ pkg/model/deployment.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/deployment_chain.pb.go--- pkg/model/deployment_chain.pb.go.orig
+++ pkg/model/deployment_chain.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/piped.pb.go--- pkg/model/piped.pb.go.orig
+++ pkg/model/piped.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/project.pb.go--- pkg/model/project.pb.go.orig
+++ pkg/model/project.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/app/helloworld/service/service.pb.go--- pkg/app/helloworld/service/service.pb.go.orig
+++ pkg/app/helloworld/service/service.pb.go
@@ -21,11 +21,12 @@
package service
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/application_live_state.pb.go--- pkg/model/application_live_state.pb.go.orig
+++ pkg/model/application_live_state.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/event.pb.go--- pkg/model/event.pb.go.orig
+++ pkg/model/event.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/insight.pb.go--- pkg/model/insight.pb.go.orig
+++ pkg/model/insight.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/role.pb.go--- pkg/model/role.pb.go.orig
+++ pkg/model/role.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
descriptorpb "google.golang.org/protobuf/types/descriptorpb"
- reflect "reflect"
- sync "sync"
)
const (
|
khanhtc1202
reviewed
Mar 4, 2022
| } | ||
|
|
||
| containers := d.Spec.Template.Spec.Containers | ||
| // remove duplicate images on multiple manifests |
Member
There was a problem hiding this comment.
Suggested change
| // remove duplicate images on multiple manifests | |
| // Remove duplicate images on multiple manifests. |
As our convention, comments start with a capital character and finish with a dot.
khanhtc1202
reviewed
Mar 4, 2022
| // e.g. Scale from 10 to 100 replicas. | ||
| // e.g. Update image from v1.5.0 to v1.6.0. | ||
| string summary = 22; | ||
| string version = 23; |
Member
There was a problem hiding this comment.
not really related to this PR but please add a TODO to remind removing this version from the deployment object later
TODO: Remove version from deployment model.
Collaborator
|
Code coverage for javascript is |
Collaborator
|
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use Details1. Determine container image version from other workload kinds such as StatefulSet, Pod, Daemon, CronJob...pipecd/pkg/app/piped/planner/kubernetes/kubernetes.go Lines 501 to 504 in c23e18a This was created by todo plugin since "TODO:" was found in c23e18a when #3340 was merged. cc: @ffjlabo.2. Remove version from deployment model.pipecd/pkg/model/deployment.proto Lines 79 to 82 in c23e18a This was created by todo plugin since "TODO:" was found in c23e18a when #3340 was merged. cc: @ffjlabo. |
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/app/server/service/apiservice/service.pb.go--- pkg/app/server/service/apiservice/service.pb.go.orig
+++ pkg/app/server/service/apiservice/service.pb.go
@@ -21,12 +21,14 @@
package apiservice
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
- model "github.com/pipe-cd/pipecd/pkg/model"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
+
+ model "github.com/pipe-cd/pipecd/pkg/model"
)
const (
pkg/app/server/service/webservice/service_grpc.pb.go--- pkg/app/server/service/webservice/service_grpc.pb.go.orig
+++ pkg/app/server/service/webservice/service_grpc.pb.go
@@ -4,6 +4,7 @@
import (
context "context"
+
grpc "google.golang.org/grpc"
codes "google.golang.org/grpc/codes"
status "google.golang.org/grpc/status"
pkg/model/deployment.pb.go--- pkg/model/deployment.pb.go.orig
+++ pkg/model/deployment.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/deployment_chain.pb.go--- pkg/model/deployment_chain.pb.go.orig
+++ pkg/model/deployment_chain.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/app/helloworld/service/service_grpc.pb.go--- pkg/app/helloworld/service/service_grpc.pb.go.orig
+++ pkg/app/helloworld/service/service_grpc.pb.go
@@ -4,6 +4,7 @@
import (
context "context"
+
grpc "google.golang.org/grpc"
codes "google.golang.org/grpc/codes"
status "google.golang.org/grpc/status"
pkg/model/application.pb.go--- pkg/model/application.pb.go.orig
+++ pkg/model/application.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/event.pb.go--- pkg/model/event.pb.go.orig
+++ pkg/model/event.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/logblock.pb.go--- pkg/model/logblock.pb.go.orig
+++ pkg/model/logblock.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/app/server/service/apiservice/service_grpc.pb.go--- pkg/app/server/service/apiservice/service_grpc.pb.go.orig
+++ pkg/app/server/service/apiservice/service_grpc.pb.go
@@ -4,6 +4,7 @@
import (
context "context"
+
grpc "google.golang.org/grpc"
codes "google.golang.org/grpc/codes"
status "google.golang.org/grpc/status"
pkg/app/server/service/pipedservice/service.pb.go--- pkg/app/server/service/pipedservice/service.pb.go.orig
+++ pkg/app/server/service/pipedservice/service.pb.go
@@ -21,12 +21,14 @@
package pipedservice
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
- model "github.com/pipe-cd/pipecd/pkg/model"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
+
+ model "github.com/pipe-cd/pipecd/pkg/model"
)
const (
pkg/model/analysis_result.pb.go--- pkg/model/analysis_result.pb.go.orig
+++ pkg/model/analysis_result.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/apikey.pb.go--- pkg/model/apikey.pb.go.orig
+++ pkg/model/apikey.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/command.pb.go--- pkg/model/command.pb.go.orig
+++ pkg/model/command.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/insight.pb.go--- pkg/model/insight.pb.go.orig
+++ pkg/model/insight.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/piped.pb.go--- pkg/model/piped.pb.go.orig
+++ pkg/model/piped.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/planpreview.pb.go--- pkg/model/planpreview.pb.go.orig
+++ pkg/model/planpreview.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/app/helloworld/service/service.pb.go--- pkg/app/helloworld/service/service.pb.go.orig
+++ pkg/app/helloworld/service/service.pb.go
@@ -21,11 +21,12 @@
package service
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/app/server/service/webservice/service.pb.go--- pkg/app/server/service/webservice/service.pb.go.orig
+++ pkg/app/server/service/webservice/service.pb.go
@@ -21,13 +21,15 @@
package webservice
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
- model "github.com/pipe-cd/pipecd/pkg/model"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
wrapperspb "google.golang.org/protobuf/types/known/wrapperspb"
- reflect "reflect"
- sync "sync"
+
+ model "github.com/pipe-cd/pipecd/pkg/model"
)
const (
pkg/model/application_live_state.pb.go--- pkg/model/application_live_state.pb.go.orig
+++ pkg/model/application_live_state.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/common.pb.go--- pkg/model/common.pb.go.orig
+++ pkg/model/common.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/notificationevent.pb.go--- pkg/model/notificationevent.pb.go.orig
+++ pkg/model/notificationevent.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/piped_stat.pb.go--- pkg/model/piped_stat.pb.go.orig
+++ pkg/model/piped_stat.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/project.pb.go--- pkg/model/project.pb.go.orig
+++ pkg/model/project.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
pkg/model/role.pb.go--- pkg/model/role.pb.go.orig
+++ pkg/model/role.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
descriptorpb "google.golang.org/protobuf/types/descriptorpb"
- reflect "reflect"
- sync "sync"
)
const (
pkg/app/server/service/pipedservice/service_grpc.pb.go--- pkg/app/server/service/pipedservice/service_grpc.pb.go.orig
+++ pkg/app/server/service/pipedservice/service_grpc.pb.go
@@ -4,6 +4,7 @@
import (
context "context"
+
grpc "google.golang.org/grpc"
codes "google.golang.org/grpc/codes"
status "google.golang.org/grpc/status"
pkg/model/user.pb.go--- pkg/model/user.pb.go.orig
+++ pkg/model/user.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
|
Collaborator
|
Code coverage for golang is
|
Member
|
Nice 👍 |
Member
|
Great work. |
Member
|
/approve |
Collaborator
|
This pull request is APPROVED by Approvers can cancel the approval by writing |
This was referenced Mar 4, 2022
This was referenced Mar 17, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add rich version info to KubernetesApp Deployment
Which issue(s) this PR fixes:
A part of #3303
Does this PR introduce a user-facing change?: