Refresh generated code #3353

nghialv · 2022-03-04T11:49:21Z

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

pipecd-bot · 2022-03-04T11:49:22Z

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Remove version from deployment model.

pipecd/pkg/model/deployment.pb.go

Lines 247 to 250 in 4d894b8

    
           // TODO: Remove version from deployment model. 
        
           Version  string             `protobuf:"bytes,23,opt,name=version,proto3" json:"version,omitempty"` 
        
           Versions []*ArtifactVersion `protobuf:"bytes,24,rep,name=versions,proto3" json:"versions,omitempty"` 
        
           // Hash value of the most recently successfully deployed commit.

This was created by todo plugin since "TODO:" was found in `4d894b8` when #3353 was merged. cc: @nghialv.

pipecd-bot · 2022-03-04T11:50:15Z

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/model/event.pb.go

--- pkg/model/event.pb.go.orig
+++ pkg/model/event.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/piped.pb.go

--- pkg/model/piped.pb.go.orig
+++ pkg/model/piped.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/role.pb.go

--- pkg/model/role.pb.go.orig
+++ pkg/model/role.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
 	descriptorpb "google.golang.org/protobuf/types/descriptorpb"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/user.pb.go

--- pkg/model/user.pb.go.orig
+++ pkg/model/user.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/app/helloworld/service/service.pb.go

--- pkg/app/helloworld/service/service.pb.go.orig
+++ pkg/app/helloworld/service/service.pb.go
@@ -21,11 +21,12 @@
 package service
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/app/server/service/webservice/service.pb.go

--- pkg/app/server/service/webservice/service.pb.go.orig
+++ pkg/app/server/service/webservice/service.pb.go
@@ -21,13 +21,15 @@
 package webservice
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
-	model "github.com/pipe-cd/pipecd/pkg/model"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
 	wrapperspb "google.golang.org/protobuf/types/known/wrapperspb"
-	reflect "reflect"
-	sync "sync"
+
+	model "github.com/pipe-cd/pipecd/pkg/model"
 )
 
 const (

pkg/model/application_live_state.pb.go

--- pkg/model/application_live_state.pb.go.orig
+++ pkg/model/application_live_state.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/piped_stat.pb.go

--- pkg/model/piped_stat.pb.go.orig
+++ pkg/model/piped_stat.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/project.pb.go

--- pkg/model/project.pb.go.orig
+++ pkg/model/project.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/app/helloworld/service/service_grpc.pb.go

--- pkg/app/helloworld/service/service_grpc.pb.go.orig
+++ pkg/app/helloworld/service/service_grpc.pb.go
@@ -8,6 +8,7 @@
 
 import (
 	context "context"
+
 	grpc "google.golang.org/grpc"
 	codes "google.golang.org/grpc/codes"
 	status "google.golang.org/grpc/status"

pkg/app/server/service/apiservice/service.pb.go

--- pkg/app/server/service/apiservice/service.pb.go.orig
+++ pkg/app/server/service/apiservice/service.pb.go
@@ -21,12 +21,14 @@
 package apiservice
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
-	model "github.com/pipe-cd/pipecd/pkg/model"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
+
+	model "github.com/pipe-cd/pipecd/pkg/model"
 )
 
 const (

pkg/model/apikey.pb.go

--- pkg/model/apikey.pb.go.orig
+++ pkg/model/apikey.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/deployment.pb.go

--- pkg/model/deployment.pb.go.orig
+++ pkg/model/deployment.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/insight.pb.go

--- pkg/model/insight.pb.go.orig
+++ pkg/model/insight.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/logblock.pb.go

--- pkg/model/logblock.pb.go.orig
+++ pkg/model/logblock.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/planpreview.pb.go

--- pkg/model/planpreview.pb.go.orig
+++ pkg/model/planpreview.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/app/server/service/webservice/service_grpc.pb.go

--- pkg/app/server/service/webservice/service_grpc.pb.go.orig
+++ pkg/app/server/service/webservice/service_grpc.pb.go
@@ -8,6 +8,7 @@
 
 import (
 	context "context"
+
 	grpc "google.golang.org/grpc"
 	codes "google.golang.org/grpc/codes"
 	status "google.golang.org/grpc/status"

pkg/model/application.pb.go

--- pkg/model/application.pb.go.orig
+++ pkg/model/application.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/command.pb.go

--- pkg/model/command.pb.go.orig
+++ pkg/model/command.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/analysis_result.pb.go

--- pkg/model/analysis_result.pb.go.orig
+++ pkg/model/analysis_result.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/common.pb.go

--- pkg/model/common.pb.go.orig
+++ pkg/model/common.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/deployment_chain.pb.go

--- pkg/model/deployment_chain.pb.go.orig
+++ pkg/model/deployment_chain.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/model/notificationevent.pb.go

--- pkg/model/notificationevent.pb.go.orig
+++ pkg/model/notificationevent.pb.go
@@ -21,11 +21,12 @@
 package model
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
 )
 
 const (

pkg/app/server/service/apiservice/service_grpc.pb.go

--- pkg/app/server/service/apiservice/service_grpc.pb.go.orig
+++ pkg/app/server/service/apiservice/service_grpc.pb.go
@@ -8,6 +8,7 @@
 
 import (
 	context "context"
+
 	grpc "google.golang.org/grpc"
 	codes "google.golang.org/grpc/codes"
 	status "google.golang.org/grpc/status"

pkg/app/server/service/pipedservice/service.pb.go

--- pkg/app/server/service/pipedservice/service.pb.go.orig
+++ pkg/app/server/service/pipedservice/service.pb.go
@@ -21,12 +21,14 @@
 package pipedservice
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
-	model "github.com/pipe-cd/pipecd/pkg/model"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
-	reflect "reflect"
-	sync "sync"
+
+	model "github.com/pipe-cd/pipecd/pkg/model"
 )
 
 const (

pkg/app/server/service/pipedservice/service_grpc.pb.go

--- pkg/app/server/service/pipedservice/service_grpc.pb.go.orig
+++ pkg/app/server/service/pipedservice/service_grpc.pb.go
@@ -8,6 +8,7 @@
 
 import (
 	context "context"
+
 	grpc "google.golang.org/grpc"
 	codes "google.golang.org/grpc/codes"
 	status "google.golang.org/grpc/status"

pipecd-bot · 2022-03-04T11:50:45Z

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

pipecd-bot · 2022-03-04T11:55:30Z

Code coverage for golang is 32.45%. This pull request does not change code coverage.

pipecd-bot · 2022-03-04T11:59:30Z

Code coverage for javascript is 78.01%. This pull request decreases coverage by -0.08%.

File	Base	Head	Diff
src/modules/commands/index.ts	`93.75%`	`90.62%`	`-3.12%`
src/modules/project/index.ts	`60.38%`	`56.60%`	`-3.77%`

Refresh generated code

4d894b8

pipecd-bot added release-note-none area/helloworld area/server size/XXL labels Mar 4, 2022

pipecd-bot requested a review from khanhtc1202 March 4, 2022 11:49

pipecd-bot added the area/web label Mar 4, 2022

pipecd-bot requested a review from knanao March 4, 2022 11:49

khanhtc1202 approved these changes Mar 4, 2022

View reviewed changes

pipecd-bot added the approved label Mar 4, 2022

nghialv merged commit e3bdcc1 into master Mar 4, 2022

pipecd-bot deleted the fix-codegen branch March 4, 2022 11:53

pipecd-bot mentioned this pull request Mar 4, 2022

Remove version from deployment model. #3354

Closed

pipecd-bot mentioned this pull request Mar 8, 2022

Move launcher config to config package #3362

Merged

This was referenced Mar 17, 2022

Fix bug that the specified kubeConfigPath in Piped config was not used while handling manifests #3410

Merged

Use the latest codegen #3414

Merged

Delete unneeded CODEOWNERS file #3416

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Refresh generated code #3353

Refresh generated code #3353

Uh oh!

nghialv commented Mar 4, 2022

Uh oh!

pipecd-bot commented Mar 4, 2022

1. Remove version from deployment model.

This was created by todo plugin since "TODO:" was found in `4d894b8` when #3353 was merged. cc: @nghialv.

Uh oh!

pipecd-bot commented Mar 4, 2022

Uh oh!

pipecd-bot commented Mar 4, 2022

Uh oh!

pipecd-bot commented Mar 4, 2022

Uh oh!

pipecd-bot commented Mar 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Refresh generated code #3353

Refresh generated code #3353

Uh oh!

Conversation

nghialv commented Mar 4, 2022

Uh oh!

pipecd-bot commented Mar 4, 2022

1. Remove version from deployment model.

This was created by todo plugin since "TODO:" was found in 4d894b8 when #3353 was merged. cc: @nghialv.

Uh oh!

pipecd-bot commented Mar 4, 2022

Uh oh!

pipecd-bot commented Mar 4, 2022

Uh oh!

pipecd-bot commented Mar 4, 2022

Uh oh!

pipecd-bot commented Mar 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

This was created by todo plugin since "TODO:" was found in `4d894b8` when #3353 was merged. cc: @nghialv.