Skip to content

Enable to view Application live state for Cloud Run #3301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pipecd-bot merged 5 commits into from
Feb 22, 2022
Merged

Enable to view Application live state for Cloud Run #3301

pipecd-bot merged 5 commits into from
Feb 22, 2022

Conversation

@knanao
Copy link
Member

@knanao knanao commented Feb 21, 2022 •
edited
Loading

What this PR does / why we need it:

Resource overview
Screen Shot 2022-02-21 at 20 29 48

Resource detail
Screen Shot 2022-02-21 at 20 29 58

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Enable to view Application live state for Cloud Run

@knanao knanao changed the title Add Application live state view for Cloud Run Enable to view Application live state for Cloud Run Feb 21, 2022
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Feb 21, 2022

COVERAGE

Code coverage for golang is 32.40%. This pull request increases coverage by 0.07%.

File Function Base Head Diff
pkg/app/piped/planner/kubernetes/kubernetes.go findUpdatedWorkloads 93.33% 100.00% +6.67%
pkg/app/piped/planner/kubernetes/kubernetes.go checkImageChange 30.77% 100.00% +69.23%

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Feb 21, 2022

COVERAGE

Code coverage for javascript is 77.96%. This pull request decreases coverage by -0.79%.

File Base Head Diff
src/components/application-detail-page/application-state-view/cloudrun-state-view/index.tsx -- 33.33% +33.33%
src/components/application-detail-page/application-state-view/cloudrun-state-view/cloudrun-resource/index.tsx -- 80.00% +80.00%
src/components/application-detail-page/application-state-view/cloudrun-state-view/cloudrun-resource-detail/index.tsx -- 84.62% +84.62%
src/components/application-detail-page/application-state-view/cloudrun-state-view/cloudrun-resource/health-status-icon/index.tsx -- 72.22% +72.22%
src/components/application-detail-page/application-state-view/index.tsx 78.95% 76.74% -2.20%
src/modules/applications-live-state/index.ts 96.88% 96.97% +0.09%

@nghialv
Copy link
Member

nghialv commented Feb 22, 2022

Great! You made my day.
/lgtm

@pipecd-bot pipecd-bot added lgtm and removed lgtm labels Feb 22, 2022
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Feb 22, 2022

COVERAGE

Code coverage for golang is 32.40%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Feb 22, 2022

COVERAGE

Code coverage for javascript is 78.02%. This pull request decreases coverage by -0.77%.

File Base Head Diff
src/components/application-detail-page/application-state-view/cloudrun-state-view/index.tsx -- 33.33% +33.33%
src/components/application-detail-page/application-state-view/cloudrun-state-view/cloudrun-resource/index.tsx -- 80.00% +80.00%
src/components/application-detail-page/application-state-view/cloudrun-state-view/cloudrun-resource-detail/index.tsx -- 84.62% +84.62%
src/components/application-detail-page/application-state-view/cloudrun-state-view/cloudrun-resource/health-status-icon/index.tsx -- 72.22% +72.22%
src/modules/applications-live-state/index.ts 96.88% 96.97% +0.09%
src/modules/commands/index.ts 90.62% 93.75% +3.12%
src/components/application-detail-page/application-state-view/index.tsx 78.95% 76.74% -2.20%

@khanhtc1202
Copy link
Member

khanhtc1202 commented Feb 22, 2022

Please run make web-lint to fix lint issue on web source 🙌

@knanao @khanhtc1202
Update pkg/app/web/src/components/application-detail-page/application…
2b155c4 
…-state-view/cloudrun-state-view/index.tsx

Co-authored-by: Khanh Tran <[email protected]>
@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Feb 22, 2022

COVERAGE

Code coverage for golang is 32.55%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Feb 22, 2022

COVERAGE

Code coverage for javascript is 77.99%. This pull request decreases coverage by -0.79%.

File Base Head Diff
src/components/application-detail-page/application-state-view/cloudrun-state-view/index.tsx -- 33.90% +33.90%
src/components/application-detail-page/application-state-view/cloudrun-state-view/cloudrun-resource/index.tsx -- 80.00% +80.00%
src/components/application-detail-page/application-state-view/cloudrun-state-view/cloudrun-resource-detail/index.tsx -- 84.62% +84.62%
src/components/application-detail-page/application-state-view/cloudrun-state-view/cloudrun-resource/health-status-icon/index.tsx -- 72.22% +72.22%
src/modules/project/index.ts 60.38% 56.60% -3.77%
src/components/application-detail-page/application-state-view/index.tsx 78.95% 76.74% -2.20%
src/modules/applications-live-state/index.ts 96.88% 96.97% +0.09%

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Feb 22, 2022

COVERAGE

Code coverage for golang is 32.55%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Feb 22, 2022

COVERAGE

Code coverage for javascript is 78.07%. This pull request decreases coverage by -0.72%.

File Base Head Diff
src/components/application-detail-page/application-state-view/cloudrun-state-view/index.tsx -- 34.48% +34.48%
src/components/application-detail-page/application-state-view/cloudrun-state-view/cloudrun-resource/index.tsx -- 80.00% +80.00%
src/components/application-detail-page/application-state-view/cloudrun-state-view/cloudrun-resource-detail/index.tsx -- 84.62% +84.62%
src/components/application-detail-page/application-state-view/cloudrun-state-view/cloudrun-resource/health-status-icon/index.tsx -- 72.22% +72.22%
src/components/application-detail-page/application-state-view/index.tsx 78.95% 76.74% -2.20%
src/modules/applications-live-state/index.ts 96.88% 96.97% +0.09%

@khanhtc1202
Copy link
Member

khanhtc1202 commented Feb 22, 2022

Nice work 🙌
/approve

@pipecd-bot
Copy link
Collaborator

pipecd-bot commented Feb 22, 2022

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 9d970cd into master Feb 22, 2022
@pipecd-bot pipecd-bot deleted the livestateview branch February 22, 2022 04:49
@pipecd-bot pipecd-bot mentioned this pull request Mar 1, 2022
Merged
@pipecd-bot pipecd-bot mentioned this pull request Mar 8, 2022
Merged
This was referenced Mar 17, 2022
Merged
Merged
Merged
@t-kikuc t-kikuc mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khanhtc1202 khanhtc1202 khanhtc1202 left review comments

@nghialv nghialv Awaiting requested review from nghialv

Assignees

No one assigned

Labels

approved area/web size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@knanao @pipecd-bot @nghialv @khanhtc1202