Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: avoid excluding symlinks in recursive fs.readdir with filetypes #55714

Merged
merged 1 commit into from
Nov 25, 2024
Merged

lib: avoid excluding symlinks in recursive fs.readdir with filetypes #55714

merged 1 commit into from
Nov 25, 2024

Conversation

juanarbol
Copy link
Member

Fixes: #52663

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 4, 2024
@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 4, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63415/

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (6af5c4e) to head (a8a6aa0).
Report is 96 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55714      +/-   ##
==========================================
+ Coverage   88.41%   88.42%   +0.01%     
==========================================
  Files         654      654              
  Lines      187757   187863     +106     
  Branches    36129    36148      +19     
==========================================
+ Hits       166003   166119     +116     
+ Misses      14997    14982      -15     
- Partials     6757     6762       +5
Files with missing lines Coverage Δ
lib/fs.js 98.26% <100.00%> (+0.11%) ⬆️

... and 54 files with indirect coverage changes

---- 🚨 Try these New Features:

@Ethan-Arrowood
Copy link
Contributor

Please add a test; otherwise lgtm

@Ethan-Arrowood Ethan-Arrowood self-assigned this Nov 6, 2024
@juanarbol
Copy link
Member Author

Please add a test; otherwise lgtm

Will do

@juanarbol juanarbol force-pushed the juan/fs-readdir branch 2 times, most recently from 0330a1d to 10a71b9 Compare November 14, 2024 01:36
@juanarbol
Copy link
Member Author

@Ethan-Arrowood there we go!

@juanarbol
Copy link
Member Author

@Ethan-Arrowood you were right, I've addressed your suggestions and tested the thing w/ main branch build.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63608/

@juanarbol
Copy link
Member Author

ping @Ethan-Arrowood

Ethan-Arrowood
Ethan-Arrowood approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Ethan-Arrowood Ethan-Arrowood added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 21, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63651/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63656/

@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 24, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63683/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 24, 2024 •
edited by jazelly
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/63690/ 💛

@juanarbol juanarbol added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit c9bf257 into nodejs:main Nov 25, 2024
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c9bf257

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
@juanarbol @Ceres6
lib: avoid excluding symlinks in recursive fs.readdir with filetypes
2d9858a 
Fixes: nodejs#52663
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: nodejs#55714
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@juanarbol @aduh95
lib: avoid excluding symlinks in recursive fs.readdir with filetypes
30f26ba 
Fixes: #52663
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #55714
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 6, 2024
Closed
Closed
Closed
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@juanarbol @aduh95
lib: avoid excluding symlinks in recursive fs.readdir with filetypes
366c270 
Fixes: #52663
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #55714
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@juanarbol @aduh95
lib: avoid excluding symlinks in recursive fs.readdir with filetypes
ce505c8 
Fixes: #52663
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #55714
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@juanarbol @aduh95
lib: avoid excluding symlinks in recursive fs.readdir with filetypes
0e36fd9 
Fixes: #52663
Signed-off-by: Juan José Arboleda <[email protected]>
PR-URL: #55714
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@jasnell jasnell jasnell approved these changes

Assignees

@Ethan-Arrowood Ethan-Arrowood

Labels
fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

withFileTypes has different behavior in fs.readdir when reading symbolic directories
4 participants
@juanarbol @nodejs-github-bot @Ethan-Arrowood @jasnell