Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite: deps include sqlite3ext.h #56010

Merged

Conversation

himself65
Copy link
Member

@himself65 himself65 commented Nov 27, 2024

This is a pre-requirement of #53900, I need this header file to build extension from source code

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. tools Issues and PRs related to the tools directory. labels Nov 27, 2024
@himself65 himself65 requested a review from cjihrig November 27, 2024 00:31
@himself65 himself65 force-pushed the himself65/20241126/include_ext branch from 47ea81c to 0c383db Compare November 27, 2024 00:31
@himself65 himself65 changed the title deps(sqlite): include sqlite3ext.h sqlite: deps include sqlite3ext.h Nov 27, 2024
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 27, 2024
@himself65 himself65 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 28, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/56010
✔  Done loading data for nodejs/node/pull/56010
----------------------------------- PR info ------------------------------------
Title      sqlite: deps include `sqlite3ext.h` (#56010)
Author     Alex Yang <[email protected]> (@himself65)
Branch     himself65:himself65/20241126/include_ext -> nodejs:main
Labels     tools, author ready, needs-ci, dependencies, sqlite
Commits    1
 - sqlite: deps include `sqlite3ext.h`
Committers 1
 - Alex Yang <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/56010
Reviewed-By: Colin Ihrig <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/56010
Reviewed-By: Colin Ihrig <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 27 Nov 2024 00:30:11 GMT
   ✔  Approvals: 1
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/56010#pullrequestreview-2465240184
   ✘  This PR needs to wait 119 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ✘  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/12077031263

@himself65 himself65 added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

@himself65 himself65 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 29, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 29, 2024
@nodejs-github-bot nodejs-github-bot merged commit 22792b8 into nodejs:main Nov 29, 2024
69 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 22792b8

@himself65 himself65 deleted the himself65/20241126/include_ext branch November 29, 2024 18:12
targos pushed a commit that referenced this pull request Dec 2, 2024
PR-URL: #56010
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56010
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56010
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56010
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56010
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56010
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56010
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56010
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants