assert: optimize partial comparison of two Sets
#55970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
assert
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #55970 +/- ##
==========================================
- Coverage 88.00% 88.00% -0.01%
==========================================
Files 653 653
Lines 188091 188083 -8
Branches 35946 35949 +3
==========================================
- Hits 165526 165517 -9
+ Misses 15739 15732 -7
- Partials 6826 6834 +8
|
targos
approved these changes
Nov 24, 2024
github-actions
bot
removed
the
request-ci
aduh95
added
the
author ready
atlowChemi
approved these changes
Nov 24, 2024
aduh95
added
the
commit-queue
lpinca
approved these changes
Nov 24, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in a43a283 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55970 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
added a commit
that referenced
this pull request
Nov 26, 2024
PR-URL: #55970 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Dec 6, 2024
aduh95
added a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #55970 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
added a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #55970 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
added a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #55970 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can skip the conversion to an array of the expected items as we're only iterating over them. Using a labelled
continueshould also slightly improve perf as we no longer need to keep afoundboolean value and check its value.I'm also removing the
TODOthat no longer applies (I suggested adding it when there were plans for aassert.includesmethod in the PR which have since been abandoned). Lastly I'm using theSafeSetmethods to iterate over theSetinstances to be consistent with how we iterate overMapinstances just a few lines above.