Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: convert readdir test to use test runner #55750

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

tchetwin
Copy link
Contributor

@tchetwin tchetwin commented Nov 6, 2024

This PR is the result of a code & learn session at NodeConf EU 2024 in Waterford, Ireland.

It was part of a wider initiative to update Node.js tests to make use of the new built-in test apparatus.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 6, 2024
@pmarchini pmarchini added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Nov 6, 2024
@tchetwin tchetwin force-pushed the test-refactor branch 2 times, most recently from 9857f8e to f2fe5a5 Compare November 6, 2024 15:47
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (1aa7135) to head (7598397).
Report is 103 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55750      +/-   ##
==========================================
+ Coverage   88.40%   88.41%   +0.01%     
==========================================
  Files         654      654              
  Lines      187747   187757      +10     
  Branches    36127    36131       +4     
==========================================
+ Hits       165972   166009      +37     
+ Misses      15009    14998      -11     
+ Partials     6766     6750      -16     

see 33 files with indirect coverage changes

---- 🚨 Try these New Features:

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@pmarchini pmarchini requested a review from BridgeAR November 13, 2024 15:08
@pmarchini pmarchini added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 23, 2024
@nodejs-github-bot nodejs-github-bot merged commit e92499c into nodejs:main Nov 23, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in e92499c

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
Signed-off-by: tchetwin <[email protected]>
PR-URL: nodejs#55750
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
Signed-off-by: tchetwin <[email protected]>
PR-URL: #55750
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
Signed-off-by: tchetwin <[email protected]>
PR-URL: #55750
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
Signed-off-by: tchetwin <[email protected]>
PR-URL: #55750
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
Signed-off-by: tchetwin <[email protected]>
PR-URL: #55750
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants