crypto: ensure CryptoKey usages and algorithm are cached objects #56108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
|
panva
added
request-ci
|
cc @nodejs/web-standards |
github-actions
bot
removed
the
request-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56108 +/- ##
==========================================
+ Coverage 87.96% 88.00% +0.03%
==========================================
Files 656 656
Lines 188383 188981 +598
Branches 35975 35993 +18
==========================================
+ Hits 165716 166308 +592
+ Misses 15842 15832 -10
- Partials 6825 6841 +16
|
KhafraDev
approved these changes
Dec 2, 2024
panva
added
the
author ready
anonrig
approved these changes
Dec 2, 2024
panva
added
the
commit-queue
lpinca
approved these changes
Dec 3, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 4e44322 |
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#56108 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#56108 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
targos
pushed a commit
that referenced
this pull request
Dec 6, 2024
PR-URL: #56108 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #56108 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #56108 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #56108 Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the spec both the
usagesandalgorithmare "cached", i.e. not new objects every time the getter is invoked.This fixes the behaviour for
usagesand adds tests for both.