Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update WPT updater #56003

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 26, 2024

Update the workflow to support subsystems that contains non alphanumeric char. Remove the Jenkins token as it is unused. Update external actions.

@aduh95 aduh95 requested a review from panva November 26, 2024 17:30
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 26, 2024
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 26, 2024
@anonrig anonrig added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 26, 2024
Copy link
Contributor

Fast-track has been requested by @anonrig. Please 👍 to approve.

Update the workflow to support subsystems that contains non alphanumeric
char. Remove the Jenkins token as it is unused. Update external actions.
Use shorter ref for upstream commits.
@aduh95 aduh95 force-pushed the wpt-updater-update branch from 80052a2 to 7404318 Compare November 26, 2024 18:11
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 26, 2024

I've pushed another commit to also use shorter ref to not exceed the commit message limit. I've tested it with aduh95#14.

@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2024
@nodejs-github-bot nodejs-github-bot merged commit 7450332 into nodejs:main Nov 26, 2024
16 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 7450332

@aduh95 aduh95 deleted the wpt-updater-update branch November 26, 2024 21:32
targos pushed a commit that referenced this pull request Dec 2, 2024
Update the workflow to support subsystems that contains non alphanumeric
char. Remove the Jenkins token as it is unused. Update external actions.
Use shorter ref for upstream commits.

PR-URL: #56003
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
github-actions bot pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
Update the workflow to support subsystems that contains non alphanumeric
char. Remove the Jenkins token as it is unused. Update external actions.
Use shorter ref for upstream commits.

PR-URL: nodejs#56003
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
Update the workflow to support subsystems that contains non alphanumeric
char. Remove the Jenkins token as it is unused. Update external actions.
Use shorter ref for upstream commits.

PR-URL: nodejs#56003
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
Update the workflow to support subsystems that contains non alphanumeric
char. Remove the Jenkins token as it is unused. Update external actions.
Use shorter ref for upstream commits.

PR-URL: nodejs#56003
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
Update the workflow to support subsystems that contains non alphanumeric
char. Remove the Jenkins token as it is unused. Update external actions.
Use shorter ref for upstream commits.

PR-URL: nodejs#56003
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
Update the workflow to support subsystems that contains non alphanumeric
char. Remove the Jenkins token as it is unused. Update external actions.
Use shorter ref for upstream commits.

PR-URL: nodejs#56003
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 added a commit to aduh95/node that referenced this pull request Dec 4, 2024
Update the workflow to support subsystems that contains non alphanumeric
char. Remove the Jenkins token as it is unused. Update external actions.
Use shorter ref for upstream commits.

PR-URL: nodejs#56003
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 added a commit that referenced this pull request Dec 13, 2024
Update the workflow to support subsystems that contains non alphanumeric
char. Remove the Jenkins token as it is unused. Update external actions.
Use shorter ref for upstream commits.

PR-URL: #56003
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 added a commit that referenced this pull request Dec 13, 2024
Update the workflow to support subsystems that contains non alphanumeric
char. Remove the Jenkins token as it is unused. Update external actions.
Use shorter ref for upstream commits.

PR-URL: #56003
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
aduh95 added a commit that referenced this pull request Dec 13, 2024
Update the workflow to support subsystems that contains non alphanumeric
char. Remove the Jenkins token as it is unused. Update external actions.
Use shorter ref for upstream commits.

PR-URL: #56003
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants