build: fix C string encoding for PRODUCT_DIR_ABS
#56111
Closed
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
This was referenced Dec 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56111 +/- ##
=======================================
Coverage 88.53% 88.54%
=======================================
Files 657 657
Lines 189858 189858
Branches 36450 36447 -3
=======================================
+ Hits 168089 168103 +14
+ Misses 14973 14972 -1
+ Partials 6796 6783 -13 |
anonrig
approved these changes
Dec 3, 2024
addaleax
force-pushed
the
gyp-handle-cstring-productdir
branch
from
e0c8ce0 to
c2bec3f
Compare
addaleax
added
request-ci
github-actions
bot
removed
the
request-ci
|
@addaleax The build is broken, can you take a look ? also long time no see :) |
|
Yeah, thanks for pointing this out – nodejs/gyp-next#274 should fix this again (sorry, I applied the suggestion provided there without checking that it works when integrated into Node.js again) |
Since the `PRODUCT_DIR_ABS` gyp variable is meant to be used in a C string in the OpenSSL config, provide a version of it that actually provides it in a way that is always usable as a C string. Otherwise, unescaped characters in the path can mess with the string definitions; for example, building in paths on Windows whose directories start with valid or invalid escape sequences (e.g.: `C:\...\x61foobar\...` or `C:\...\456789\...`) can result in failing builds or incorrect paths provided to OpenSSL.
addaleax
force-pushed
the
gyp-handle-cstring-productdir
branch
from
c2bec3f to
486ff15
Compare
|
@gengjiawen Updated! 🙂 |
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Dec 11, 2024
addaleax
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e5524ea...203398d |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
PR-URL: #56111 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Dec 12, 2024
Since the `PRODUCT_DIR_ABS` gyp variable is meant to be used in a C string in the OpenSSL config, provide a version of it that actually provides it in a way that is always usable as a C string. Otherwise, unescaped characters in the path can mess with the string definitions; for example, building in paths on Windows whose directories start with valid or invalid escape sequences (e.g.: `C:\...\x61foobar\...` or `C:\...\456789\...`) can result in failing builds or incorrect paths provided to OpenSSL. PR-URL: #56111 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
PRODUCT_DIR_ABSgyp variable is meant to be used in a C string in the OpenSSL config, provide a version of it that actually provides it in a way that is always usable as a C string. Otherwise, unescaped characters in the path can mess with the string definitions; for example, building in paths on Windows whose directories start with valid or invalid escape sequences (e.g.:C:\...\x61foobar\...orC:\...\456789\...) can result in failing builds or incorrect paths provided to OpenSSL.Needs: nodejs/gyp-next#271