Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make x509 crypto tests work with BoringSSL #55927

Merged
merged 4 commits into from
Nov 22, 2024
Merged

test: make x509 crypto tests work with BoringSSL #55927

merged 4 commits into from
Nov 22, 2024

Conversation

codebytere
Copy link
Member

As in title. Tweaks a few checks parallel/test-crypto-x509.js in so they work with BoringSSL

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 20, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (1d01ad6) to head (12e14d8).
Report is 15 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #55927      +/-   ##
==========================================
+ Coverage   88.01%   88.49%   +0.48%     
==========================================
  Files         653      653              
  Lines      187735   187728       -7     
  Branches    35874    36183     +309     
==========================================
+ Hits       165229   166137     +908     
+ Misses      15693    14818     -875     
+ Partials     6813     6773      -40

see 100 files with indirect coverage changes

---- 🚨 Try these New Features:

@codebytere codebytere added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63638/

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 20, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
LiviaMedeiros
LiviaMedeiros reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@LiviaMedeiros LiviaMedeiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regexp without boundaries would allow extraneous symbols before or after the hex value.

test/parallel/test-crypto-x509.js Outdated Show resolved Hide resolved
test/parallel/test-crypto-x509.js Outdated Show resolved Hide resolved
test/parallel/test-crypto-x509.js Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63640/

@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 21, 2024
@codebytere codebytere added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Nov 21, 2024
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 22, 2024
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/55927
✔  Done loading data for nodejs/node/pull/55927
----------------------------------- PR info ------------------------------------
Title      test: make x509 crypto tests work with BoringSSL (#55927)
Author     Shelley Vohr <[email protected]> (@codebytere)
Branch     codebytere:upstream-boringssl-x509-compat -> nodejs:main
Labels     test, author ready
Commits    4
 - test: make x509 crypto tests work with BoringSSL
 - Update test/parallel/test-crypto-x509.js
 - Update test/parallel/test-crypto-x509.js
 - Update test/parallel/test-crypto-x509.js
Committers 2
 - Shelley Vohr <[email protected]>
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/55927
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/55927
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 20 Nov 2024 09:16:37 GMT
   ✔  Approvals: 3
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/55927#pullrequestreview-2448627030
   ✔  - LiviaMedeiros (@LiviaMedeiros): https://github.com/nodejs/node/pull/55927#pullrequestreview-2448822391
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55927#pullrequestreview-2449682404
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2024-11-20T14:41:40Z: https://ci.nodejs.org/job/node-test-pull-request/63640/
- Querying data for job/node-test-pull-request/63640/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 55927
From https://github.com/nodejs/node
 * branch                  refs/pull/55927/merge -> FETCH_HEAD
✔  Fetched commits as ead8bd157a94..12e14d86d35b
--------------------------------------------------------------------------------
[main 6fd53725ee] test: make x509 crypto tests work with BoringSSL
 Author: Shelley Vohr <[email protected]>
 Date: Tue Nov 19 14:25:37 2024 +0100
 1 file changed, 16 insertions(+), 14 deletions(-)
[main fe330968bd] Update test/parallel/test-crypto-x509.js
 Author: Shelley Vohr <[email protected]>
 Date: Wed Nov 20 15:37:28 2024 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 881454a9a3] Update test/parallel/test-crypto-x509.js
 Author: Shelley Vohr <[email protected]>
 Date: Wed Nov 20 15:37:36 2024 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 643442c061] Update test/parallel/test-crypto-x509.js
 Author: Shelley Vohr <[email protected]>
 Date: Wed Nov 20 15:38:01 2024 +0100
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 4 commits in the PR. Attempting autorebase.
Rebasing (2/8)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
test: make x509 crypto tests work with BoringSSL

PR-URL: #55927

Reviewed-By: Richard Lau <[email protected]>

Reviewed-By: LiviaMedeiros <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>


[detached HEAD d2e3ad3923] test: make x509 crypto tests work with BoringSSL

Author: Shelley Vohr <[email protected]>

Date: Tue Nov 19 14:25:37 2024 +0100

1 file changed, 16 insertions(+), 14 deletions(-)

Rebasing (3/8)

Rebasing (4/8)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update test/parallel/test-crypto-x509.js


Co-authored-by: Livia Medeiros <[email protected]>

PR-URL: #55927

Reviewed-By: Richard Lau <[email protected]>

Reviewed-By: LiviaMedeiros <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>


[detached HEAD dfda673878] Update test/parallel/test-crypto-x509.js

Author: Shelley Vohr <[email protected]>

Date: Wed Nov 20 15:37:28 2024 +0100

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (5/8)

Rebasing (6/8)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update test/parallel/test-crypto-x509.js


Co-authored-by: Livia Medeiros <[email protected]>

PR-URL: #55927

Reviewed-By: Richard Lau <[email protected]>

Reviewed-By: LiviaMedeiros <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>


[detached HEAD 9e1e91365f] Update test/parallel/test-crypto-x509.js

Author: Shelley Vohr <[email protected]>

Date: Wed Nov 20 15:37:36 2024 +0100

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (7/8)

Rebasing (8/8)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

Update test/parallel/test-crypto-x509.js


Co-authored-by: Livia Medeiros <[email protected]>

PR-URL: #55927

Reviewed-By: Richard Lau <[email protected]>

Reviewed-By: LiviaMedeiros <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>


[detached HEAD b33308f488] Update test/parallel/test-crypto-x509.js

Author: Shelley Vohr <[email protected]>

Date: Wed Nov 20 15:38:01 2024 +0100

1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/11969824102

@LiviaMedeiros LiviaMedeiros added needs-ci PRs that need a full CI run. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Nov 22, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 22, 2024
@nodejs-github-bot nodejs-github-bot merged commit 3178a76 into nodejs:main Nov 22, 2024
75 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3178a76

@codebytere codebytere deleted the upstream-boringssl-x509-compat branch November 22, 2024 11:18
@codebytere codebytere removed the needs-ci PRs that need a full CI run. label Nov 23, 2024
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
@codebytere @Ceres6
test: make x509 crypto tests work with BoringSSL
791b5b5 
PR-URL: nodejs#55927
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@codebytere @aduh95
test: make x509 crypto tests work with BoringSSL
29362ce 
PR-URL: #55927
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Closed
aduh95 pushed a commit that referenced this pull request Dec 10, 2024
@codebytere @aduh95
test: make x509 crypto tests work with BoringSSL
2f3298a 
PR-URL: #55927
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Dec 11, 2024
Closed
Closed
@ruyadorno ruyadorno mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codebytere @nodejs-github-bot @lpinca @richardlau @LiviaMedeiros