Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use std::string_view for process emit fns #56086

Merged
merged 1 commit into from
Dec 2, 2024
Merged

src: use std::string_view for process emit fns #56086

merged 1 commit into from
Dec 2, 2024
+35 −34

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Nov 29, 2024

We should use std::string_view instead of const char* because we need the length for better creating a string in V8.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Nov 29, 2024
@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 29, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 29, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63791/

@codecov Codecov
Copy link

codecov bot commented Nov 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 88.00%. Comparing base (4efb7ae) to head (23065b2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/node_process_events.cc 38.46% 3 Missing and 5 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #56086   +/-   ##
=======================================
  Coverage   87.99%   88.00%           
=======================================
  Files         656      656           
  Lines      188988   189005   +17     
  Branches    35988    35982    -6     
=======================================
+ Hits       166302   166330   +28     
+ Misses      15848    15844    -4     
+ Partials     6838     6831    -7
Files with missing lines Coverage Δ
src/node_process.h 25.00% <ø> (ø)
src/node_process_events.cc 59.01% <38.46%> (-4.07%) ⬇️

... and 29 files with indirect coverage changes

@anonrig anonrig added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Nov 29, 2024
@anonrig anonrig force-pushed the yagiz/use-string-view-in-process-events branch from 23065b2 to 05d80a6 Compare November 30, 2024 00:00
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63833/

@anonrig anonrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Dec 2, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit 8bd9a84 into nodejs:main Dec 2, 2024
92 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 8bd9a84

targos pushed a commit that referenced this pull request Dec 3, 2024
@anonrig @targos
src: use std::string_view for process emit fns
56c4da2 
PR-URL: #56086
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@anonrig @nodejs-github-bot
src: use std::string_view for process emit fns
5878196 
PR-URL: nodejs#56086
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
This was referenced Dec 6, 2024
Closed
Closed
Closed
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@anonrig @aduh95
src: use std::string_view for process emit fns
f76dc86 
PR-URL: #56086
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@anonrig @aduh95
src: use std::string_view for process emit fns
4694513 
PR-URL: #56086
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@anonrig @aduh95
src: use std::string_view for process emit fns
4d8d012 
PR-URL: #56086
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@juanarbol juanarbol juanarbol approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@anonrig @nodejs-github-bot @jasnell @addaleax @juanarbol @mertcanaltin