Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: include openssl/rand.h explicitly #55425

Merged
merged 1 commit into from
Oct 19, 2024
Merged

crypto: include openssl/rand.h explicitly #55425

merged 1 commit into from
Oct 19, 2024

Conversation

codebytere
Copy link
Member

IWYU #include fix that also rectifies the following errors in Electron during build:

../../third_party/electron_node/deps/ncrypto/ncrypto.cc:308:14: error: use of undeclared identifier 'RAND_status'
  308 |     if (1 == RAND_status()) {
      |              ^
../../third_party/electron_node/deps/ncrypto/ncrypto.cc:314:39: error: use of undeclared identifier 'RAND_bytes'
  314 |       while (length > INT_MAX && 1 == RAND_bytes(buf, INT_MAX)) {
      |                                       ^
../../third_party/electron_node/deps/ncrypto/ncrypto.cc:318:37: error: use of undeclared identifier 'RAND_bytes'
  318 |       if (length <= INT_MAX && 1 == RAND_bytes(buf, static_cast<int>(length)))
      |                                     ^
../../third_party/electron_node/deps/ncrypto/ncrypto.cc:336:17: error: use of undeclared identifier 'RAND_poll'
  336 |   } while (1 == RAND_poll());
      |                 ^
4 errors generated.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Oct 17, 2024
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 17, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63161/

@RedYetiDev RedYetiDev added crypto Issues and PRs related to the crypto subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Oct 17, 2024
@panva panva mentioned this pull request Oct 17, 2024
Merged
@marco-ippolito marco-ippolito added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 18, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 99c6e4e into nodejs:main Oct 19, 2024
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 99c6e4e

@codebytere codebytere removed the needs-ci PRs that need a full CI run. label Oct 22, 2024
aduh95 pushed a commit that referenced this pull request Oct 23, 2024
@codebytere @aduh95
crypto: include openssl/rand.h explicitly
adead26 
PR-URL: #55425
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95 aduh95 mentioned this pull request Oct 24, 2024
Merged
@codebytere codebytere mentioned this pull request Oct 31, 2024
Merged
5 tasks
louwers pushed a commit to louwers/node that referenced this pull request Nov 2, 2024
@codebytere @louwers
crypto: include openssl/rand.h explicitly
d59faf5 
PR-URL: nodejs#55425
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. dependencies Pull requests that update a dependency file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@codebytere @nodejs-github-bot @jasnell @addaleax @lpinca @anonrig @richardlau @marco-ippolito @RedYetiDev