Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: fix outdated js2c.cc references #56133

Merged
merged 1 commit into from
Dec 11, 2024
Merged

src: fix outdated js2c.cc references #56133

merged 1 commit into from
Dec 11, 2024

Conversation

legendecas
Copy link
Member

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Dec 4, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.98%. Comparing base (3bb1d28) to head (028180a).
Report is 109 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56133      +/-   ##
==========================================
+ Coverage   87.95%   87.98%   +0.03%     
==========================================
  Files         656      656              
  Lines      188310   188999     +689     
  Branches    35963    35985      +22     
==========================================
+ Hits       165630   166295     +665     
- Misses      15854    15867      +13     
- Partials     6826     6837      +11
Files with missing lines Coverage Δ
src/node_builtins.h 100.00% <ø> (ø)

... and 73 files with indirect coverage changes

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63893/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63908/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63912/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63961/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 11, 2024
@nodejs-github-bot nodejs-github-bot merged commit 64cc3b8 into nodejs:main Dec 11, 2024
68 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 64cc3b8

@legendecas legendecas deleted the src/js2c-cc branch December 11, 2024 19:31
targos pushed a commit that referenced this pull request Dec 13, 2024
@legendecas @targos
src: fix outdated js2c.cc references
3968599 
PR-URL: #56133
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: Franziska Hinkelmann <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@legendecas @nodejs-github-bot @fhinkel @lpinca @anonrig @joyeecheung @juanarbol