sqlite: add support for custom functions #55985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55985 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.01%
==========================================
Files 657 657
Lines 189970 190149 +179
Branches 36482 36516 +34
==========================================
+ Hits 168200 168348 +148
- Misses 14979 14986 +7
- Partials 6791 6815 +24
|
targos
reviewed
Nov 25, 2024
| @@ -132,6 +132,31 @@ This method allows one or more SQL statements to be executed without returning | |||
| any results. This method is useful when executing SQL statements read from a | |||
| file. This method is a wrapper around [`sqlite3_exec()`][]. | |||
|
|
|||
| ### `database.function(name[, options], function)` | |||
There was a problem hiding this comment.
Two questions:
- Why isn't the optional parameter the last one?
- Why not call it
createFunction? I think that makes the method more self-explanatory.
There was a problem hiding this comment.
The boring answer to both questions is "because that's how better-sqlite3 does it."
himself65
reviewed
Dec 9, 2024
github-actions
bot
removed
the
request-ci
himself65
approved these changes
Dec 10, 2024
jasnell
reviewed
Dec 10, 2024
This commit adds support to node:sqlite for defining custom functions that can be invoked from SQL. Fixes: nodejs#54349
cjihrig
force-pushed
the
sqlite-funcs
branch
from
9909463 to
e0435f0
Compare
github-actions
bot
removed
the
request-ci
cjihrig
added
author ready
jasnell
approved these changes
Dec 12, 2024
cjihrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e5524ea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support to node:sqlite for defining custom functions that can be invoked from SQL.
Fixes: #54349