doc: mention tools/release -a option #56124
Merged
+7
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
RafaelGSS
reviewed
Dec 3, 2024
| @@ -966,6 +966,13 @@ a `NODEJS_RELEASE_HOST` environment variable: | |||
| NODEJS_RELEASE_HOST=proxy.xyz ./tools/release.sh | |||
| ``` | |||
|
|
|||
| In case `gpg` is unable to autoselect a key, you can retry using the | |||
There was a problem hiding this comment.
How can we do it with git node release prepare?
There was a problem hiding this comment.
as far as I can tell, based on today's run, git node release promote default behavior will just stop and ask you to run it in a separate shell, like this:
✔ Ready to continue? yes
ℹ You are running in dry-run mode, meaning NCU will not run the `git push` commands, you would need to copy-paste the following command in another terminal window. Alternatively, pass `--run` flag to ask NCU to run the command for you (might not work if you need to type a passphrase to push to the remote).
ℹ Run the following command to sign and promote the release:
ℹ ./tools/release.sh -i <keyPath>
There was a problem hiding this comment.
I believe the autodetect feature needs to be 100% in case you want to run it in --run mode, otherwise we should put extra validation along the way to catch it early on in case values like these are unable to be retrieved
RafaelGSS
approved these changes
Dec 3, 2024
Document that running `./tools/release.sh` script using the recently added `-a` CLI flag enables the previously-default interactive interface to select the correct PGP key.
aduh95
force-pushed
the
release-doc-mention-tools-release-a-option
branch
from
d9e0f4f to
0a1dcae
Compare
aduh95
approved these changes
Dec 4, 2024
aduh95
added
author ready
richardlau
approved these changes
Dec 4, 2024
nodejs-github-bot
removed
the
commit-queue
|
Landed in 660d533 |
nodejs-github-bot
deleted the
release-doc-mention-tools-release-a-option
branch
targos
pushed a commit
that referenced
this pull request
Dec 6, 2024
Document that running `./tools/release.sh` script using the recently added `-a` CLI flag enables the previously-default interactive interface to select the correct PGP key. PR-URL: #56124 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
Document that running `./tools/release.sh` script using the recently added `-a` CLI flag enables the previously-default interactive interface to select the correct PGP key. PR-URL: #56124 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
Document that running `./tools/release.sh` script using the recently added `-a` CLI flag enables the previously-default interactive interface to select the correct PGP key. PR-URL: #56124 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
Document that running `./tools/release.sh` script using the recently added `-a` CLI flag enables the previously-default interactive interface to select the correct PGP key. PR-URL: #56124 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Richard Lau <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention that running
./tools/release.shscript using the recently added-aoption enables the previously-default interactive interface to select the correct GPG key.