Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add vetted courses to the ambassador benefits #55934

Merged
merged 1 commit into from
Nov 25, 2024
Merged

doc: add vetted courses to the ambassador benefits #55934

merged 1 commit into from
Nov 25, 2024

Conversation

mcollina
Copy link
Member

@mcollina mcollina requested a review from mhdawson November 20, 2024 15:49
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 20, 2024
BridgeAR
BridgeAR approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avivkeller
Copy link
Member

CC @nodejs/nodejs-website

AugustinMauroy
AugustinMauroy approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT ! I like that

RafaelGSS
RafaelGSS reviewed Nov 20, 2024
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not comfortable with the paid courses on the list, but I won't object unless someone else feels the same way as me.

@AugustinMauroy
Copy link
Member

I'm still not comfortable with the paid courses on the list, but I won't object unless someone else feels the same way as me.

I agree with you that highlighting paid content is 'borderline'. But what we have here is a good compromise.

mhdawson
mhdawson approved these changes Nov 20, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 25, 2024
@nodejs-github-bot nodejs-github-bot merged commit abd95a8 into nodejs:main Nov 25, 2024
22 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in abd95a8

Ceres6 pushed a commit to Ceres6/node that referenced this pull request Nov 26, 2024
@mcollina @Ceres6
doc: add vetted courses to the ambassador benefits
5e07ecf 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: nodejs#55934
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@mcollina @aduh95
doc: add vetted courses to the ambassador benefits
7705724 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #55934
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 28, 2024
Closed
Closed
This was referenced Nov 28, 2024
Closed
Closed
Closed
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 6, 2024
Closed
Closed
Closed
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@mcollina @aduh95
doc: add vetted courses to the ambassador benefits
bea385a 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #55934
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@mcollina @aduh95
doc: add vetted courses to the ambassador benefits
0295c2b 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #55934
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@mcollina @aduh95
doc: add vetted courses to the ambassador benefits
5808a07 
Signed-off-by: Matteo Collina <[email protected]>
PR-URL: #55934
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS left review comments

@AugustinMauroy AugustinMauroy AugustinMauroy approved these changes

@aymen94 aymen94 aymen94 approved these changes

@mhdawson mhdawson mhdawson approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Vetted Courses
10 participants
@mcollina @nodejs-github-bot @avivkeller @AugustinMauroy @jasnell @BridgeAR @mhdawson @aymen94 @RafaelGSS @lpinca