doc: sort --report-exclude alphabetically #55788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
cli
richardlau
approved these changes
Nov 8, 2024
RafaelGSS
added
fast-track
|
Fast-track has been requested by @RafaelGSS. Please 👍 to approve. |
|
I'll upgrade the linter to verify these are alphabetical. I'll open a PR once this lands, as then the linter will pass. |
lpinca
approved these changes
Nov 9, 2024
RafaelGSS
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55788 ✔ Done loading data for nodejs/node/pull/55788 ----------------------------------- PR info ------------------------------------ Title doc: sort --report-exclude alphabetically (#55788) Author Rafael Gonzaga <[email protected]> (@RafaelGSS) Branch RafaelGSS:sort-report-exclude-alphabetically -> nodejs:main Labels doc, cli, fast-track, author ready Commits 1 - doc: sort --report-exclude alphabetically Committers 1 - RafaelGSS <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55788 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55788 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 08 Nov 2024 18:05:54 GMT ✔ Approvals: 2 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/55788#pullrequestreview-2424652242 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/55788#pullrequestreview-2425273068 ℹ This PR is being fast-tracked ✘ This PR needs to wait 30 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/11756015774 |
UlisesGascon
approved these changes
Nov 9, 2024
UlisesGascon
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 0a00217 |
aduh95
added
dont-land-on-v18.x
aduh95
pushed a commit
that referenced
this pull request
Nov 16, 2024
PR-URL: #55788 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
tpoisseau
pushed a commit
to tpoisseau/node
that referenced
this pull request
Nov 21, 2024
PR-URL: nodejs#55788 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55788 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
|
This commit does not land cleanly on |
ruyadorno
added
the
backport-requested-v22.x
RafaelGSS
added a commit
to RafaelGSS/node
that referenced
this pull request
Dec 3, 2024
PR-URL: nodejs#55788 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]>
RafaelGSS
added
backport-open-v22.x
aduh95
pushed a commit
to RafaelGSS/node
that referenced
this pull request
Dec 10, 2024
PR-URL: nodejs#55788 Backport-PR-URL: nodejs#56055 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ulises Gascón <[email protected]> PR-URL: nodejs#55697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #55697 (comment)