Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix deprecation codes #56018

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

panva
Copy link
Member

@panva panva commented Nov 27, 2024

#55545 introduced a duplicate deprecation code and because of it CI is now failing

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Nov 27, 2024
@panva panva added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 27, 2024
Copy link
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
@nodejs-github-bot nodejs-github-bot merged commit 5bdf1c4 into nodejs:main Nov 27, 2024
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 5bdf1c4

@panva panva deleted the fix-deprecation-codes branch November 27, 2024 14:03
targos pushed a commit that referenced this pull request Dec 2, 2024
PR-URL: #56018
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
github-actions bot pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56018
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56018
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
PR-URL: nodejs#56018
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56018
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56018
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
PR-URL: #56018
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants