tools: filter release keys to reduce interactivity #55950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
approved these changes
Nov 23, 2024
anonrig
approved these changes
Nov 23, 2024
RafaelGSS
approved these changes
Nov 24, 2024
juanarbol
approved these changes
Nov 27, 2024
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5ae07d0 |
targos
pushed a commit
that referenced
this pull request
Dec 2, 2024
PR-URL: #55950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
github-actions bot
pushed a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#55950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#55950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#55950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#55950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#55950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
aduh95
added a commit
to aduh95/node
that referenced
this pull request
Dec 4, 2024
PR-URL: nodejs#55950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
This was referenced Dec 6, 2024
aduh95
added a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #55950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
aduh95
added a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #55950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
aduh95
added a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #55950 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I might be wrong, but I think most releasers use the primary key that's listed in the README, so we can make the script autoselect it by default, reducing the need for the releaser to interact with the script when selecting the key.
/cc @nodejs/releasers