Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: move history entry to class description #55991

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 25, 2024

Move the history entry for the TextDecoder class into the class description itself instead of its constructor.

Refs: #55938

Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: nodejs#55938
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module. labels Nov 25, 2024
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 25, 2024
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
@nodejs-github-bot nodejs-github-bot merged commit db8ff56 into nodejs:main Nov 27, 2024
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in db8ff56

@lpinca lpinca deleted the move/histroy-entry-to-class branch November 27, 2024 14:27
targos pushed a commit that referenced this pull request Dec 2, 2024
Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: #55938
PR-URL: #55991
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
github-actions bot pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: nodejs#55938
PR-URL: nodejs#55991
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: nodejs#55938
PR-URL: nodejs#55991
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: nodejs#55938
PR-URL: nodejs#55991
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: nodejs#55938
PR-URL: nodejs#55991
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: nodejs#55938
PR-URL: nodejs#55991
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: nodejs#55938
PR-URL: nodejs#55991
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: #55938
PR-URL: #55991
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: #55938
PR-URL: #55991
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
Move the history entry for the `TextDecoder` class into the class
description itself instead of its constructor.

Refs: #55938
PR-URL: #55991
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants