Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: remove confusing and outdated sentence #55988

Merged
merged 1 commit into from
Nov 27, 2024
Merged

doc: remove confusing and outdated sentence #55988

merged 1 commit into from
Nov 27, 2024

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 25, 2024

Remove confusing and outdated sentence in doc/api/stream.md.

Fixes: #55987

@lpinca
doc: remove confusing and outdated sentence
982270b 
Remove confusing and outdated sentence in `doc/api/stream.md`.

Fixes: nodejs#55987
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Nov 25, 2024
@lpinca lpinca added fast-track PRs that do not need to wait for 48 hours to land. and removed doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. labels Nov 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@aduh95 aduh95 added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Nov 25, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
@nodejs-github-bot nodejs-github-bot merged commit 17f39bc into nodejs:main Nov 27, 2024
42 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 17f39bc

@lpinca lpinca deleted the fix/issue-55987 branch November 27, 2024 10:35
targos pushed a commit that referenced this pull request Dec 2, 2024
@lpinca @targos
doc: remove confusing and outdated sentence
fa2b35d 
Remove confusing and outdated sentence in `doc/api/stream.md`.

Fixes: #55987
PR-URL: #55988
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
github-actions bot pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@lpinca @nodejs-github-bot
doc: remove confusing and outdated sentence
b62e643 
Remove confusing and outdated sentence in `doc/api/stream.md`.

Fixes: nodejs#55987
PR-URL: nodejs#55988
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@lpinca @nodejs-github-bot
doc: remove confusing and outdated sentence
2323e09 
Remove confusing and outdated sentence in `doc/api/stream.md`.

Fixes: nodejs#55987
PR-URL: nodejs#55988
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@lpinca @nodejs-github-bot
doc: remove confusing and outdated sentence
7d2436e 
Remove confusing and outdated sentence in `doc/api/stream.md`.

Fixes: nodejs#55987
PR-URL: nodejs#55988
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@lpinca @nodejs-github-bot
doc: remove confusing and outdated sentence
443a33f 
Remove confusing and outdated sentence in `doc/api/stream.md`.

Fixes: nodejs#55987
PR-URL: nodejs#55988
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@lpinca @nodejs-github-bot
doc: remove confusing and outdated sentence
5972486 
Remove confusing and outdated sentence in `doc/api/stream.md`.

Fixes: nodejs#55987
PR-URL: nodejs#55988
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@lpinca @nodejs-github-bot
doc: remove confusing and outdated sentence
82b244c 
Remove confusing and outdated sentence in `doc/api/stream.md`.

Fixes: nodejs#55987
PR-URL: nodejs#55988
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@github-actions github-actions bot mentioned this pull request Dec 6, 2024
Closed
This was referenced Dec 11, 2024
Closed
Closed
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@lpinca @aduh95
doc: remove confusing and outdated sentence
5c9303c 
Remove confusing and outdated sentence in `doc/api/stream.md`.

Fixes: #55987
PR-URL: #55988
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@lpinca @aduh95
doc: remove confusing and outdated sentence
0c165e7 
Remove confusing and outdated sentence in `doc/api/stream.md`.

Fixes: #55987
PR-URL: #55988
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@lpinca @aduh95
doc: remove confusing and outdated sentence
43244d8 
Remove confusing and outdated sentence in `doc/api/stream.md`.

Fixes: #55987
PR-URL: #55988
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

@jazelly jazelly jazelly approved these changes

@aduh95 aduh95 aduh95 approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Confusing and outdated tidbit in streams documentation
7 participants
@lpinca @nodejs-github-bot @anonrig @aduh95 @jazelly @jakecastelli @LiviaMedeiros