-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: order crypto methods alphabetically #55831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
nodejs-github-bot
added
crypto
Issues and PRs related to the crypto subsystem.
doc
Issues and PRs related to the documentations.
labels
Nov 13, 2024
I've found some more who are out of order:
FWIW, here's the script I've used, so we can be confident we're forgetting any: $0.querySelectorAll('ul').forEach(ul => console.log(Array.from(ul.children, li => li.textContent.split('(', 1)[0]).find((t, i, l) => t < l[i-1]))) If you can push one commit per section that you move, that would make reviewing easier :) |
aduh95
reviewed
Nov 20, 2024
jasnell
approved these changes
Nov 23, 2024
aduh95
approved these changes
Nov 23, 2024
aduh95
added
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue
Add this label to land a pull request using GitHub Actions.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
and removed
commit-queue
Add this label to land a pull request using GitHub Actions.
labels
Nov 23, 2024
Landed in a2a0c22 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55831 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
PR-URL: #55831 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Dec 6, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #55831 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #55831 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Dec 13, 2024
PR-URL: #55831 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
crypto
Issues and PRs related to the crypto subsystem.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55801