Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve GN build documentation a bit #55968

Merged
merged 1 commit into from
Nov 27, 2024
Merged

doc: improve GN build documentation a bit #55968

merged 1 commit into from
Nov 27, 2024

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Nov 23, 2024 •
edited
Loading

As in title. With my last few commits as well as some i've made upstream to node-ci, the GN build now compiles on Windows:

NORTHAMERICA+cavohr@CODEBYTERE-WIN-WORK CLANGARM64 ~/Developer/node_gn/node ((95ad75b...))
$ ./out/Release/node.exe
Welcome to Node.js v24.0.0-pre.
Type ".help" for more information.
>

This adds some Windows-specific notes to documentation.

@codebytere codebytere requested a review from zcbenz November 23, 2024 10:19
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 23, 2024
joyeecheung
joyeecheung approved these changes Nov 23, 2024
View reviewed changes
Copy link
Member

@joyeecheung joyeecheung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for improving the docs!

@codebytere codebytere force-pushed the more-documentation-gn-build branch from e0209f9 to 212b193 Compare November 25, 2024 14:54
@codebytere codebytere added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 27, 2024
@nodejs-github-bot nodejs-github-bot merged commit c6d3fdd into nodejs:main Nov 27, 2024
17 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in c6d3fdd

targos pushed a commit that referenced this pull request Dec 2, 2024
@codebytere @targos
doc: improve GN build documentation a bit
e92d51d 
PR-URL: #55968
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
github-actions bot pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@codebytere @nodejs-github-bot
doc: improve GN build documentation a bit
c612057 
PR-URL: nodejs#55968
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@codebytere @nodejs-github-bot
doc: improve GN build documentation a bit
0251a62 
PR-URL: nodejs#55968
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@codebytere @nodejs-github-bot
doc: improve GN build documentation a bit
e929ee9 
PR-URL: nodejs#55968
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@codebytere @nodejs-github-bot
doc: improve GN build documentation a bit
9e6e5d5 
PR-URL: nodejs#55968
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@codebytere @nodejs-github-bot
doc: improve GN build documentation a bit
24bdb14 
PR-URL: nodejs#55968
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@codebytere @nodejs-github-bot
doc: improve GN build documentation a bit
d161546 
PR-URL: nodejs#55968
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
This was referenced Dec 6, 2024
Closed
Closed
Closed
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@codebytere @aduh95
doc: improve GN build documentation a bit
3c6991a 
PR-URL: #55968
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@codebytere @aduh95
doc: improve GN build documentation a bit
16149ba 
PR-URL: #55968
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@codebytere @aduh95
doc: improve GN build documentation a bit
638f96f 
PR-URL: #55968
Reviewed-By: Joyee Cheung <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stefan Stojanovic <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@juanarbol juanarbol juanarbol approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@codebytere @nodejs-github-bot @jasnell @lpinca @joyeecheung @StefanStojanovic @juanarbol @RafaelGSS