tools: add linter for release commit proposals #55923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
the
meta
anonrig
approved these changes
Nov 19, 2024
atlowChemi
approved these changes
Nov 20, 2024
marco-ippolito
added
the
author ready
marco-ippolito
approved these changes
Nov 20, 2024
aduh95
added
lts-watch-v18.x
|
Landed in 02921e1 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55923 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
aduh95
added a commit
that referenced
this pull request
Nov 26, 2024
PR-URL: #55923 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
aduh95
added a commit
that referenced
this pull request
Dec 10, 2024
PR-URL: #55923 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it's way too simple to forget about the
PR-URL: TODOtrailer – in fact, it has slipped through in some releases. Another thing that has happened to me is when postponing a release, I would remember to amend the date in the commit message but not in the CHANGELOG.Let's add some automation that ensure we catch those kind of mistakes early.