Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: set node_arch to target_cpu in GN #55967

Merged
merged 1 commit into from
Nov 26, 2024
Merged

build: set node_arch to target_cpu in GN #55967

merged 1 commit into from
Nov 26, 2024

Conversation

codebytere
Copy link
Member

When building Node.js using the GN build, it would fail when cross-compiling, e.g.

./tools/gn-gen.py out/Release --target_cpu=arm64

becuase node_arch was being improperly set to current_cpu in every case and thus the startup snapshot wouldn't match:

node/src/node_snapshotable.cc

Lines 677 to 684 in eef3030

if (metadata.node_arch != per_process::metadata.arch) {
fprintf(stderr,
"Failed to load the startup snapshot because it was built with"
"architecture %s and the architecture is %s.\n",
metadata.node_arch.c_str(),
NODE_ARCH);
return false;
}

@codebytere codebytere requested a review from zcbenz November 23, 2024 10:09
@codebytere codebytere added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 26, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0ba264f into nodejs:main Nov 26, 2024
23 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0ba264f

aduh95 pushed a commit that referenced this pull request Nov 26, 2024
@codebytere @aduh95
build: set node_arch to target_cpu in GN
ce53f16 
PR-URL: #55967
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 28, 2024
Closed
Closed
Closed
Closed
Closed
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 6, 2024
Closed
Closed
Closed
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@codebytere @aduh95
build: set node_arch to target_cpu in GN
033870d 
PR-URL: #55967
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@codebytere @aduh95
build: set node_arch to target_cpu in GN
b301fae 
PR-URL: #55967
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@codebytere @aduh95
build: set node_arch to target_cpu in GN
216a785 
PR-URL: #55967
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Juan José Arboleda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanarbol juanarbol juanarbol approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codebytere @nodejs-github-bot @jasnell @lpinca @juanarbol