Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fs: cache ReadFileContext after lazy loading #55998

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fs: cache ReadFileContext after lazy loading #55998

merged 1 commit into from
Nov 28, 2024

Conversation

gurgunday
Copy link
Contributor

@gurgunday gurgunday commented Nov 26, 2024 •
edited
Loading

Not sure why it's required at every call, I think we can cache it after the lazy load

All tests pass on my end

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Nov 26, 2024
@gurgunday gurgunday changed the title fs: lazily load ReadFileContext fs: cache ReadFileContext after lazy loading Nov 26, 2024
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 26, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63711/

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (3bb1d28) to head (c00d877).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55998   +/-   ##
=======================================
  Coverage   87.95%   87.96%           
=======================================
  Files         656      656           
  Lines      188310   188311    +1     
  Branches    35963    35970    +7     
=======================================
+ Hits       165630   165642   +12     
+ Misses      15854    15842   -12     
- Partials     6826     6827    +1
Files with missing lines Coverage Δ
lib/fs.js 93.35% <100.00%> (+<0.01%) ⬆️

... and 32 files with indirect coverage changes

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 26, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 28, 2024
@nodejs-github-bot nodejs-github-bot merged commit ba912ee into nodejs:main Nov 28, 2024
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in ba912ee

@gurgunday gurgunday deleted the lazyloadRFC branch November 28, 2024 12:09
targos pushed a commit that referenced this pull request Dec 2, 2024
@gurgunday @targos
fs: lazily load ReadFileContext
a37e5fe 
PR-URL: #55998
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
@nodejs-github-bot nodejs-github-bot mentioned this pull request Dec 3, 2024
Merged
github-actions bot pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@gurgunday @nodejs-github-bot
fs: lazily load ReadFileContext
2cae1db 
PR-URL: nodejs#55998
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@gurgunday @nodejs-github-bot
fs: lazily load ReadFileContext
643f4f3 
PR-URL: nodejs#55998
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@gurgunday @nodejs-github-bot
fs: lazily load ReadFileContext
73cbe75 
PR-URL: nodejs#55998
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@gurgunday @nodejs-github-bot
fs: lazily load ReadFileContext
ba3a5e6 
PR-URL: nodejs#55998
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
@gurgunday @nodejs-github-bot
fs: lazily load ReadFileContext
d57a16f 
PR-URL: nodejs#55998
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
This was referenced Dec 6, 2024
Closed
Closed
Closed
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@gurgunday @aduh95
fs: lazily load ReadFileContext
f452a1a 
PR-URL: #55998
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@gurgunday @aduh95
fs: lazily load ReadFileContext
933c54b 
PR-URL: #55998
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
@gurgunday @aduh95
fs: lazily load ReadFileContext
ccb10df 
PR-URL: #55998
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiviaMedeiros LiviaMedeiros LiviaMedeiros approved these changes

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@jazelly jazelly jazelly approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gurgunday @nodejs-github-bot @lpinca @anonrig @jazelly @mertcanaltin @LiviaMedeiros