doc: add create-release-action to process #55993
Conversation
|
Review requested:
|
|
https://github.com/nodejs/node/actions/workflows/create-release-proposal.yml I'd make sure it succeeds at least once before recommending in in the documentation. |
@ruyadorno will use it for next v22 release. Let's wait then. Note, I have been using the action on my local fork and it was working ok https://github.com/RafaelGSS/node/actions/workflows/create-release-proposal.yml (the last run was an old state, so do not consider the run |
It worked! 🥳 you can see the result here: #56040 Notably there are a few tweakings that we might still want to see if it can be improved, such as adding the correct attribution by using the handler of the user that triggered the action (if possible) and notable changes can probably also have a more streamlined workflow. That said, this is amazing @RafaelGSS 🤩 I'm super excited to be finally seeing all this automation taking shape! |
|
I will create a roadmap for this on nodejs/releasers repository so we can share any issues or improvement suggestions. Meanwhile, I think it's ok to land this after changing from UI to GH CLI, right? |
RafaelGSS
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/55993 ✔ Done loading data for nodejs/node/pull/55993 ----------------------------------- PR info ------------------------------------ Title doc: add create-release-action to process (#55993) Author Rafael Gonzaga <[email protected]> (@RafaelGSS) Branch RafaelGSS:mention-create-release-proposal -> nodejs:main Labels doc, author ready, commit-queue-squash Commits 2 - doc: add create-release-action to process - fixup! doc: add create-release-action to process Committers 1 - RafaelGSS <[email protected]> PR-URL: https://github.com/nodejs/node/pull/55993 Reviewed-By: Ruy Adorno <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/55993 Reviewed-By: Ruy Adorno <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 25 Nov 2024 15:36:02 GMT ✔ Approvals: 1 ✔ - Ruy Adorno (@ruyadorno) (TSC): https://github.com/nodejs/node/pull/55993#pullrequestreview-2465952345 ✘ This PR needs to wait 19 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/12108762220 |
RafaelGSS
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 742ea1c |
PR-URL: nodejs#55993 Reviewed-By: Ruy Adorno <[email protected]>
PR-URL: nodejs#55993 Reviewed-By: Ruy Adorno <[email protected]>
PR-URL: #55993 Reviewed-By: Ruy Adorno <[email protected]>
PR-URL: #55993 Reviewed-By: Ruy Adorno <[email protected]>
PR-URL: #55993 Reviewed-By: Ruy Adorno <[email protected]>
PR-URL: #55993 Reviewed-By: Ruy Adorno <[email protected]>
After #55690 it's time to suggest it's usage as a replacement of manual steps.