build: use variable for OpenSSL dep path #55928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
dependencies
codebytere
added
the
embedding
zcbenz
reviewed
Nov 20, 2024
codebytere
force-pushed
the
crypto_path_variable
branch
from
db23d8d to
a01fcea
Compare
codebytere
changed the title
zcbenz
approved these changes
Nov 20, 2024
lpinca
approved these changes
Nov 20, 2024
github-actions
bot
removed
the
request-ci
codebytere
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d3bcb97 |
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Nov 26, 2024
PR-URL: nodejs#55928 Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Nov 26, 2024
PR-URL: #55928 Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
This was referenced Nov 28, 2024
aduh95
pushed a commit
that referenced
this pull request
Dec 10, 2024
PR-URL: #55928 Reviewed-By: Cheng Zhao <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
This was referenced Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow customizing the path to Node.js crypto in the GN build
For Electron it'd be e.g.
/third_party/boringssl.