module: add module.stripTypeScriptTypes #55282

marco-ippolito · 2024-10-05T16:28:53Z

This PR introduces a new api in node:module.

Fixes: #54300

nodejs-github-bot · 2024-10-05T16:28:58Z

Review requested:

@nodejs/loaders
@nodejs/vm

doc/api/vm.md

lib/internal/modules/helpers.js

joyeecheung · 2024-10-05T18:01:32Z

I think it makes more sense for it to be just in its own API as a function, which can be used to strip the type before the text is passed into any of the vm.Script/vm.SourceTextModule/vm.compileFunction APIs. That'll also be useful for those who want to transform the text but not compile it at all. The transform option being ignored without the flag could be somewhat surprising, especially paired with cachedData which only has a length check, so it could lead to crashes when V8 tries to reparse the untransformed source for error reporting.

devsnek · 2024-10-06T07:32:47Z

there's also #54250

marco-ippolito · 2024-10-06T07:48:55Z

there's also #54250

Unfortunately it seems to have been stalled for a while.
Anyways good to review, I'm just not sure whether to be strict and throw when mode is strip-only and sourceMap is passed, otherwise will be ignored and could be counter-intuitive

codecov · 2024-10-06T09:00:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (7b5d660) to head (8532f1e).
Report is 311 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #55282   +/-   ##
=======================================
  Coverage   88.41%   88.42%           
=======================================
  Files         653      654    +1     
  Lines      187476   187552   +76     
  Branches    36083    36087    +4     
=======================================
+ Hits       165763   165839   +76     
- Misses      14946    14951    +5     
+ Partials     6767     6762    -5

Files with missing lines	Coverage Δ
lib/internal/main/eval_string.js	`80.00% <100.00%> (ø)`
lib/internal/modules/cjs/loader.js	`97.64% <100.00%> (+0.05%)`	⬆️
lib/internal/modules/esm/get_format.js	`89.32% <100.00%> (+0.04%)`	⬆️
lib/internal/modules/esm/translators.js	`93.09% <100.00%> (ø)`
lib/internal/modules/helpers.js	`98.84% <100.00%> (-0.17%)`	⬇️
lib/internal/modules/typescript.js	`100.00% <100.00%> (ø)`
lib/module.js	`100.00% <100.00%> (ø)`

... and 28 files with indirect coverage changes

lib/vm.js

legendecas · 2024-10-07T07:30:17Z

I think this could be benefited from a dedicated module parser (name bikeshed welcome), instead of vm since the updated PR doesn't involve with any code evaluation. This module could provide additional helpers to address similar needs on manipulating JS source codes.

joyeecheung · 2024-10-07T11:10:01Z

Maybe putting it on module also makes sense? Or module.typescript if we can foresee adding other typescript-related utilities in the future

marco-ippolito · 2024-10-07T11:11:24Z

I think this could be benefited from a dedicated module parser (name bikeshed welcome), instead of vm since the updated PR doesn't involve with any code evaluation. This module could provide additional helpers to address similar needs on manipulating JS source codes.

I'm ok with a new module, I think parser is ok, I'd like to hear more opinions about it
I wouldnt call it typescript and leave it more generic, maybe someone wants to add ast manipulation or bundling etc... could be the right place

marco-ippolito · 2024-10-07T12:50:08Z

If we decide to ship it I'll drop the vm commits
Pinging TSC as adding a new module seems like a big deal @nodejs/tsc

joyeecheung · 2024-10-07T14:59:09Z

If this needs to be a new module, then it should be added to

node/lib/internal/bootstrap/realm.js

Line 130 in b4e8f1b

const schemelessBlockList = new SafeSet([

to block require('parser') without the node: prefix, otherwise it breaks https://www.npmjs.com/package/parser or anyone creating an alias of parser in node_modules.

Notable changes: doc: * move typescript support to active development (Marco Ippolito) nodejs#55536 * add jazelly to collaborators (Jason Zhang) nodejs#55531 fs: * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) nodejs#55547 http: * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) nodejs#55586 module: * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) nodejs#55412 * (SEMVER-MINOR) add module.stripTypeScriptTypes (Marco Ippolito) nodejs#55282 PR-URL: TODO

PR-URL: nodejs#55282 Fixes: nodejs#54300 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Notable changes: crypto: * update root certificates to NSS 3.104 (Richard Lau) #55681 doc: * move typescript support to active development (Marco Ippolito) #55536 * add jazelly to collaborators (Jason Zhang) #55531 fs: * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547 http: * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586 module: * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412 * (SEMVER-MINOR) add module.stripTypeScriptTypes (Marco Ippolito) #55282 tools: * fix root certificate updater (Richard Lau) #55681 PR-URL: TODO

Notable changes: crypto: * update root certificates to NSS 3.104 (Richard Lau) #55681 doc: * move typescript support to active development (Marco Ippolito) #55536 * add jazelly to collaborators (Jason Zhang) #55531 fs: * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) #55547 http: * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) #55586 module: * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412 * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) #55282 PR-URL: #55741

PR-URL: nodejs#55282 Fixes: nodejs#54300 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Notable changes: crypto: * update root certificates to NSS 3.104 (Richard Lau) nodejs#55681 doc: * move typescript support to active development (Marco Ippolito) nodejs#55536 * add jazelly to collaborators (Jason Zhang) nodejs#55531 fs: * (SEMVER-MINOR) make `dirent.path` writable (Antoine du Hamel) nodejs#55547 http: * (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) nodejs#55586 module: * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) nodejs#55412 * (SEMVER-MINOR) add `module.stripTypeScriptTypes` (Marco Ippolito) nodejs#55282 PR-URL: nodejs#55741

ruyadorno · 2024-11-27T06:38:42Z

This commit does not land cleanly on v22.x-staging and will need manual backport in case we want it in v22.x.

PR-URL: nodejs#55282 Fixes: nodejs#54300 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>

PR-URL: #55282 Backport-PR-URL: #56208 Fixes: #54300 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Paolo Insogna <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Richard Lau <[email protected]>

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 crypto: * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #56142 dgram: * (SEMVER-MINOR) support blocklist in udp (theanarkh) #56087 doc: * stabilize util.styleText (Rafael Gonzaga) #56265 * move typescript support to active development (Marco Ippolito) #55536 * add LJHarb to collaborators (Jordan Harband) #56132 * (SEMVER-MINOR) add report version and history section (Chengzhong Wu) #55697 * (SEMVER-MINOR) sort --report-exclude alphabetically (Rafael Gonzaga) #55697 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 module: * (SEMVER-MINOR) only emit require(esm) warning under --trace-require-module (Joyee Cheung) #56194 * (SEMVER-MINOR) add module.stripTypeScriptTypes (Marco Ippolito) #55282 * (SEMVER-MINOR) simplify `findPackageJSON` implementation (Antoine du Hamel) #55412 * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412 net: * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075 * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076 * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078 * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 report: * (SEMVER-MINOR) fix typos in report keys and bump the version (Yuan-Ming Hsu) #56068 sqlite: * (SEMVER-MINOR) aggregate constants in a single property (Edigleysson Silva (Edy)) #56213 * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 src: * (SEMVER-MINOR) add cli option to preserve env vars on dr (Rafael Gonzaga) #55697 src,lib: * (SEMVER-MINOR) stabilize permission model (Rafael Gonzaga) #56201 util: * (SEMVER-MINOR) add sourcemap support to getCallSites (Marco Ippolito) #55589 PR-URL: TODO

Notable changes: assert: * (SEMVER-MINOR) add partialDeepStrictEqual (Giovanni Bucci) #54630 cli: * (SEMVER-MINOR) implement --trace-env and --trace-env-[js|native]-stack (Joyee Cheung) #55604 crypto: * graduate WebCryptoAPI Ed25519 and X25519 algorithms as stable (Filip Skokan) #56142 dgram: * (SEMVER-MINOR) support blocklist in udp (theanarkh) #56087 doc: * stabilize util.styleText (Rafael Gonzaga) #56265 * move typescript support to active development (Marco Ippolito) #55536 * add LJHarb to collaborators (Jordan Harband) #56132 * (SEMVER-MINOR) add report version and history section (Chengzhong Wu) #55697 * (SEMVER-MINOR) sort --report-exclude alphabetically (Rafael Gonzaga) #55697 doc,lib,src,test: * (SEMVER-MINOR) unflag sqlite module (Colin Ihrig) #55890 module: * (SEMVER-MINOR) only emit require(esm) warning under --trace-require-module (Joyee Cheung) #56194 * (SEMVER-MINOR) add module.stripTypeScriptTypes (Marco Ippolito) #55282 * (SEMVER-MINOR) simplify `findPackageJSON` implementation (Antoine du Hamel) #55412 * (SEMVER-MINOR) add `findPackageJSON` util (Jacob Smith) #55412 net: * (SEMVER-MINOR) support blocklist in net.connect (theanarkh) #56075 * (SEMVER-MINOR) add SocketAddress.parse (James M Snell) #56076 * (SEMVER-MINOR) add net.BlockList.isBlockList(value) (James M Snell) #56078 * (SEMVER-MINOR) support blocklist for net.Server (theanarkh) #56079 process: * (SEMVER-MINOR) deprecate `features.{ipv6,uv}` and `features.tls_*` (René) #55545 report: * (SEMVER-MINOR) fix typos in report keys and bump the version (Yuan-Ming Hsu) #56068 sqlite: * (SEMVER-MINOR) aggregate constants in a single property (Edigleysson Silva (Edy)) #56213 * (SEMVER-MINOR) add `StatementSync.prototype.iterate` method (tpoisseau) #54213 src: * (SEMVER-MINOR) add cli option to preserve env vars on dr (Rafael Gonzaga) #55697 src,lib: * (SEMVER-MINOR) stabilize permission model (Rafael Gonzaga) #56201 util: * (SEMVER-MINOR) add sourcemap support to getCallSites (Marco Ippolito) #55589 PR-URL: #56329

nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Oct 5, 2024

marco-ippolito added the strip-types Issues or PRs related to strip-types support label Oct 5, 2024

marco-ippolito force-pushed the vm-strip-types branch from 7c1529b to ecc1d82 Compare October 5, 2024 16:33

avivkeller reviewed Oct 5, 2024

View reviewed changes

avivkeller added the semver-minor PRs that contain new features and should be released in the next minor version. label Oct 5, 2024

marco-ippolito force-pushed the vm-strip-types branch from ecc1d82 to 56fcf17 Compare October 5, 2024 16:49

marco-ippolito requested review from joyeecheung and legendecas October 5, 2024 17:06

marco-ippolito force-pushed the vm-strip-types branch from 56fcf17 to 80fa828 Compare October 6, 2024 07:18

marco-ippolito changed the title ~~vm: add support for --experimental-strip-types~~ vm: add vm.stripTypeScriptTypes(code, options) Oct 6, 2024

marco-ippolito force-pushed the vm-strip-types branch 2 times, most recently from eca9ab2 to f41d422 Compare October 6, 2024 07:46

marco-ippolito marked this pull request as ready for review October 6, 2024 07:49

atlowChemi reviewed Oct 7, 2024

View reviewed changes

lib/vm.js Outdated Show resolved Hide resolved

lib/vm.js Outdated Show resolved Hide resolved

lib/vm.js Outdated Show resolved Hide resolved

lib/vm.js Outdated Show resolved Hide resolved

marco-ippolito force-pushed the vm-strip-types branch 2 times, most recently from 50afe56 to 9ab643f Compare October 7, 2024 07:27

marco-ippolito changed the title ~~vm: add vm.stripTypeScriptTypes(code, options)~~ lib: add parser.stripTypeScriptTypes Oct 7, 2024

marco-ippolito force-pushed the vm-strip-types branch from 76ff249 to 4fbcb6c Compare October 7, 2024 15:05

aduh95 mentioned this pull request Nov 6, 2024

2024-11-11, Version 23.2.0 (Current) #55741

Merged

ruyadorno added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Nov 27, 2024

marco-ippolito mentioned this pull request Dec 10, 2024

[v22.x backport] module: add module.stripTypeScriptTypes #56208

Closed

marco-ippolito added the backport-open-v22.x Indicate that the PR has an open backport label Dec 10, 2024

ruyadorno mentioned this pull request Dec 20, 2024

2025-01-07, Version 22.13.0 'Jod' (LTS) #56329

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

module: add module.stripTypeScriptTypes #55282

module: add module.stripTypeScriptTypes #55282

marco-ippolito commented Oct 5, 2024 •

edited

Loading

nodejs-github-bot commented Oct 5, 2024 •

edited by marco-ippolito

Loading

joyeecheung commented Oct 5, 2024 •

edited

Loading

devsnek commented Oct 6, 2024

marco-ippolito commented Oct 6, 2024 •

edited

Loading

codecov bot commented Oct 6, 2024 •

edited

Loading

legendecas commented Oct 7, 2024

joyeecheung commented Oct 7, 2024

marco-ippolito commented Oct 7, 2024 •

edited

Loading

marco-ippolito commented Oct 7, 2024 •

edited

Loading

joyeecheung commented Oct 7, 2024 •

edited

Loading

ruyadorno commented Nov 27, 2024

module: add module.stripTypeScriptTypes #55282

module: add module.stripTypeScriptTypes #55282

Conversation

marco-ippolito commented Oct 5, 2024 • edited Loading

nodejs-github-bot commented Oct 5, 2024 • edited by marco-ippolito Loading

joyeecheung commented Oct 5, 2024 • edited Loading

devsnek commented Oct 6, 2024

marco-ippolito commented Oct 6, 2024 • edited Loading

codecov bot commented Oct 6, 2024 • edited Loading

Codecov Report

legendecas commented Oct 7, 2024

joyeecheung commented Oct 7, 2024

marco-ippolito commented Oct 7, 2024 • edited Loading

marco-ippolito commented Oct 7, 2024 • edited Loading

joyeecheung commented Oct 7, 2024 • edited Loading

ruyadorno commented Nov 27, 2024

marco-ippolito commented Oct 5, 2024 •

edited

Loading

nodejs-github-bot commented Oct 5, 2024 •

edited by marco-ippolito

Loading

joyeecheung commented Oct 5, 2024 •

edited

Loading

marco-ippolito commented Oct 6, 2024 •

edited

Loading

codecov bot commented Oct 6, 2024 •

edited

Loading

marco-ippolito commented Oct 7, 2024 •

edited

Loading

marco-ippolito commented Oct 7, 2024 •

edited

Loading

joyeecheung commented Oct 7, 2024 •

edited

Loading