Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add report version section #56130

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Dec 4, 2024

It's always a pain to reference a paragraph in a large section where the paragraph is outstanding and important.

Add a section dedicated for the report version so that it can be easily referenced with URL.

Also, added a version history section to trace back the changes.

Refs: #56068

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. report Issues and PRs related to process.report. labels Dec 4, 2024
@legendecas
Copy link
Member Author

Updated with version histroy section to trace back changes.

@gireeshpunathil would you mind taking a look again? Thank you

@legendecas
Copy link
Member Author

@nodejs/diagnostics would you mind taking a look at this? Thank you!

@gireeshpunathil
Copy link
Member

LGTM again!

@RafaelGSS RafaelGSS added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 6, 2024
@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit eb5aa5f into nodejs:main Dec 6, 2024
21 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in eb5aa5f

@legendecas legendecas deleted the doc/report-version branch December 6, 2024 13:31
targos pushed a commit that referenced this pull request Dec 6, 2024
PR-URL: #56130
Refs: #56068
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@aduh95 aduh95 added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Dec 6, 2024
aduh95 pushed a commit to RafaelGSS/node that referenced this pull request Dec 7, 2024
PR-URL: nodejs#56130
Refs: nodejs#56068
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
@aduh95 aduh95 added backport-open-v22.x Indicate that the PR has an open backport and removed backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. labels Dec 7, 2024
aduh95 pushed a commit to RafaelGSS/node that referenced this pull request Dec 10, 2024
PR-URL: nodejs#56130
Backport-PR-URL: nodejs#56055
Refs: nodejs#56068
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
PR-URL: nodejs#55697
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-open-v22.x Indicate that the PR has an open backport doc Issues and PRs related to the documentations. report Issues and PRs related to process.report.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants