Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: move test-worker-arraybuffer-zerofill to parallel #56053

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 28, 2024

Move test/sequential/test-worker-arraybuffer-zerofill.js back to test/parallel/test-worker-arraybuffer-zerofill.js and remove the flaky designation.

The original issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54839
Refs: #54802

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 28, 2024
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.96%. Comparing base (24a8662) to head (2e6cf79).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #56053      +/-   ##
==========================================
- Coverage   87.97%   87.96%   -0.01%     
==========================================
  Files         656      656              
  Lines      188383   188384       +1     
  Branches    35973    35967       -6     
==========================================
- Hits       165732   165717      -15     
- Misses      15821    15829       +8     
- Partials     6830     6838       +8     

see 31 files with indirect coverage changes

@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2024
@nodejs-github-bot
Copy link
Collaborator

@LiviaMedeiros
Copy link
Contributor

The commit doesn't seem to move the file from sequential to parallel.

Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#54839
Refs: nodejs#54802
@lpinca lpinca force-pushed the remove/flaky-test-worker-arraybuffer-zerofill branch from c392ac0 to 2e6cf79 Compare November 28, 2024 13:18
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 28, 2024
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@jakecastelli
Copy link
Member

shall we give it a stress test?

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2024
@lpinca
Copy link
Member Author

lpinca commented Dec 1, 2024

shall we give it a stress test?

The stress test is sequential, so it is not very useful. It is easy to revert if needed.

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 1, 2024
@nodejs-github-bot nodejs-github-bot merged commit 3f9c6c0 into nodejs:main Dec 1, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3f9c6c0

@lpinca lpinca deleted the remove/flaky-test-worker-arraybuffer-zerofill branch December 1, 2024 10:37
targos pushed a commit that referenced this pull request Dec 2, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54839
Refs: #54802
PR-URL: #56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#54839
Refs: nodejs#54802
PR-URL: nodejs#56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#54839
Refs: nodejs#54802
PR-URL: nodejs#56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#54839
Refs: nodejs#54802
PR-URL: nodejs#56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Dec 4, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#54839
Refs: nodejs#54802
PR-URL: nodejs#56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54839
Refs: #54802
PR-URL: #56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54839
Refs: #54802
PR-URL: #56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request Dec 13, 2024
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54839
Refs: #54802
PR-URL: #56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants