Dynamically determine the correct action config struct#12798
Merged
bramkragten merged 1 commit intohome-assistant:devfrom May 26, 2022
Merged
Dynamically determine the correct action config struct#12798bramkragten merged 1 commit intohome-assistant:devfrom
bramkragten merged 1 commit intohome-assistant:devfrom
Conversation
zsarnett
approved these changes
May 26, 2022
bramkragten
added a commit
that referenced
this pull request
May 26, 2022
* Fix setting _externalAccess (#12584) * Fix enter key support for generic dialog box (#12600) * Revert #10991 (#12618) * Replace host-context with css properties * Remove "Lovelace" from Github issue templates (#12614) * Remove "Lovelace" from Github issue templates * Changes from review * Get full core logs from core (#12639) * Move YAML to first tab of Developer Tools (#12589) * Add configuration panel for Application Credentials (#12344) Co-authored-by: Zack Barett <zackbarett@hey.com> Co-authored-by: Zack <zackbarett@hey.com> * Add label for Fix issue column header in statistics developer tools (#12597) Signed-off-by: Patrick ZAJDA <patrick@zajda.fr> * RTL settings clickable list item fix (#12595) * Update src/state/translations-mixin.ts Co-authored-by: Bram Kragten <mail@bramkragten.nl> * Update following review * Update Translations to create helper (#12656) * Hide Cloud URL - Add Copy Icon (#12655) Co-authored-by: Bram Kragten <mail@bramkragten.nl> * Show script traces in logbook (#12643) * Rtl menu fix (#12561) Co-authored-by: Bram Kragten <mail@bramkragten.nl> * Use / * Update var name * Use FabBase * Update ha-fab.ts * Switch logbook calls to use the new websocket (#12665) * Add calendar trigger offsets in automation editor (#12486) * Add calendar trigger offsets in automation editor * Use duration selector for offset * Fix typing for offsets/duratons * Fix strict error handling in Markdown card templates (#12661) * Add missing label to search icon (#12671) * Update Lokalise URL (#12684) * Teach logbook about additional context data (#12667) Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> * Guard for missing backup integration (#12696) * Rtl changes (#12693) * Return focus after dialogs close (#11999) * Bumped version to 20220516.0 * Fix float-end for LTR (#12707) * Add my support for Application Credentials (#12709) * Show manage cloud link to config (#12673) * Add guard logic from PR #12181 to input select row (#12703) * Refactor logbook data fetch logic into reusable class (#12701) * Add logbook to device info page (#12714) * Add logbook to area info page (#12715) * Add missing labels in energy dashboard settings (#12722) Signed-off-by: Patrick ZAJDA <patrick@zajda.fr> * Delete focus targets for replaced dialogs (#12724) * Convert history calls to use new websocket endpoint (#12662) * Add support for OAuth2 callback via My (#12718) * Support requesting translations for multiple integrations in one request (#12704) * Support requesting translations for multiple integrations in one request - Requires home-assistant/core#71979 * onboarding as well * integrations -> integration * fix cache * short return if they are all loaded * reduce * reduce * reduce * Show the integration brand icon when there is no entity in logbook (#12713) * Support requesting multiple integration manifests in a single request (#12706) * Support requesting multiple integration manifests in a single request * only fetch if there are some to actually fetch * handle empty * not truthy, wrong language * Do not copy params Co-authored-by: Paulus Schoutsen <balloob@gmail.com> * Import all date-fns from modules (#12717) * Fix 'loading_log' string (#12712) * Bumped version to 20220518.0 * Fix python to js timestamp conversions in logbook traces (#12677) - The websocket version needs the time converted from where python stores the decimal * Update Material Design Icons to v6.7.96 (#12111) * Various RTL fixes (#12721) * Select + target picker Rtl fixes (#12711) * Add error handling for application credentials removal (#12686) * Update zwave_js data collection URL (#12666) * Use device_id instead of config entry id and node id for zwave_js (#12658) * Use device_id instead of config entry id and node id for zwave_js * Add additional cleanup from #12642 * Revert removal of multiple config entries check * Update src/panels/config/devices/device-detail/integration-elements/zwave_js/ha-device-actions-zwave_js.ts Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> * Update src/panels/config/devices/device-detail/integration-elements/zwave_js/ha-device-info-zwave_js.ts Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> * Get attributes from first state when using minimal responses (#12732) * Pass device ID to logbook if available (#12728) * Compute the icon based on the logbook state and not the current state (#12725) Co-authored-by: Bram Kragten <mail@bramkragten.nl> * Add option to compare energy graphs with previous period (#12723) Co-authored-by: Paulus Schoutsen <balloob@gmail.com> * Add an application credentials display name (#12720) Co-authored-by: Bram Kragten <mail@bramkragten.nl> Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> * Fixes logbook (#12740) * Bumped version to 20220521.0 * Stop closed event when selecting datadisk (#12749) * Use logbook livestream when requesting a time window that includes the future (#12744) * Fetch supervisor info directly (#12751) * Remove kernel and agent versions from about page (#12750) * Move `preload_stream` setting to entity settings (#12730) Co-authored-by: Zack <zackbarett@hey.com> * Use new localized context state and source in logbook (#12742) * Use new logbook streaming websocket api for cases where we need end_time (#12753) * Open Application Credentials from integration configuration flow (#12708) * Make entities and devices independent in the scene editor (#11046) Co-authored-by: Zack Barett <zackbarett@hey.com> Co-authored-by: Erik <erik@montnemery.com> Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> Co-authored-by: Paulus Schoutsen <balloob@gmail.com> * Allow setting `device_class` "outlet" again through entity settings (#12669) * Allow setting `device_class` "outlet" again through UI * Fixes * Null check deviceClass and adjust used translation * Bumped version to 20220523.0 (#12756) * Adjust logbook stream consumer to handle new metadata (#12755) * Adjust path to version info in issue template (#12760) * Add My HA link to about page to Github issue template (#12761) * RTL updates (#12745) * Add compare to energy sources table (#12762) * Fix (#12764) * Change service_data to just data (#12628) * Simplify OAuth2 authorize callback URL (#12765) * Hide hidden media player entities in media panel (#12766) * Add integration filter to Device Selector (#12680) Co-authored-by: Paulus Schoutsen <balloob@gmail.com> * Integration filter for Area Selector (#12682) Co-authored-by: Paulus Schoutsen <balloob@gmail.com> * Bump Version to 20220524.0 (#12769) * Move zwave_js node comments from device config to info page (#12625) Co-authored-by: Zack Barett <zackbarett@hey.com> Co-authored-by: Bram Kragten <mail@bramkragten.nl> * Various RTL fixes * Add controller statistics to zwave_js config dashboard (#12668) * Move Logbook and make device page better (#12763) Co-authored-by: Bram Kragten <mail@bramkragten.nl> * Move metadata to pyproject.toml (#12770) * Add aria-haspopup to button menus (#12758) Co-authored-by: Zack Barett <zackbarett@hey.com> * Hardware MVP (#12773) * Fix "unavailable" handling for climate state rendering (#12778) * Ensure state is vertically centered in more-info (#12780) * Update zwave_js/network_status WS API (#12735) * Bumped version to 20220525.0 (#12779) * Use dynamic weather domain icon + icon alignment fix weather more-info (#12781) * Fix typo in credentials removal dialog (#12784) * Handle history api being passed entity ids as CSV (#12787) * Fix history cache when there is cacheConfig (#12788) * Use Hardware Integration for System Menu (#12789) * Fix Media Player More info cramped controls (#12790) * Fix Switch as X unable to change to a new type (#12797) * Fix Zwave Alerts on device page (#12785) Co-authored-by: Bram Kragten <mail@bramkragten.nl> * Set Error if entity is unavailable (#12791) * Dynamically determine the correct action config struct (#12798) * Remove import * Hide Cloud information a bit more (#12802) * Add dynamic header/footer config determination and update struct (#12795) * Bump HAWS to 7.1.0 (#12804) * Update Narrow Order on Device Page (#12801) Co-authored-by: Bram Kragten <mail@bramkragten.nl> * Fix combo box inside dialog (#12805) * Bumped version to 20220526.0 Co-authored-by: Joakim Sørensen <ludeeus@ludeeus.dev> Co-authored-by: Steve Repsher <steverep@users.noreply.github.com> Co-authored-by: Zack Barett <zackbarett@hey.com> Co-authored-by: Yosi Levy <yosilevy@gmail.com> Co-authored-by: Philip Allgaier <mail@spacegaier.de> Co-authored-by: Allen Porter <allen@thebends.org> Co-authored-by: Patrick ZAJDA <patrick@zajda.fr> Co-authored-by: Yosi Levy <37745463+yosilevy@users.noreply.github.com> Co-authored-by: J. Nick Koston <nick@koston.org> Co-authored-by: Franck Nijhof <git@frenck.dev> Co-authored-by: Sven <85389871+wrt54g@users.noreply.github.com> Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io> Co-authored-by: Paulus Schoutsen <balloob@gmail.com> Co-authored-by: breakthestatic <breakthestatic@gmail.com> Co-authored-by: RoboMagus <68224306+RoboMagus@users.noreply.github.com> Co-authored-by: Michael Irigoyen <michael@irigoyen.dev> Co-authored-by: Raman Gupta <7243222+raman325@users.noreply.github.com> Co-authored-by: David F. Mulcahey <david.mulcahey@me.com> Co-authored-by: Erik <erik@montnemery.com> Co-authored-by: Thomas Lovén <thomasloven@gmail.com> Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Improves the error handling (= better info for user) since we correctly enforce e.g. that an action of type "url" needs to have a "url_path" key in order to peroply work during action tapping.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: