Skip to content

Move YAML to first tab of Developer Tools#12589

Merged
zsarnett merged 2 commits intodevfrom
Move-yaml-to-the-start-of-dev-tools
May 9, 2022
Merged

Move YAML to first tab of Developer Tools#12589
zsarnett merged 2 commits intodevfrom
Move-yaml-to-the-start-of-dev-tools

Conversation

@zsarnett
Copy link
Copy Markdown
Contributor

@zsarnett zsarnett commented May 5, 2022

Breaking change

Proposed change

CleanShot 2022-05-04 at 20 31 22

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kinda agree with this, especially since it already members the last you've used (so most people won't notice it in their daily use).

@spacegaier
Copy link
Copy Markdown
Member

This will also somewhat resolve the issue that users with big setups have reported where loading the "States" tab takes a long time. If they go to the tab by design, the load time of course stays the same, but by setting "YAML" as the new initial tab, that gets circumvented for all users that just want o check the config and never actually go to "States".

Plus what Frank said lessens the impact for everyone else that actually needs the "States" tab often (aka devs like me that like to test UI behavior by manually manipulating states 😆).

@matthiasdebaat
Copy link
Copy Markdown
Member

I don't have a strong opinion on this, except I've seen some people ask for it. When we move YAML to the first tab, other people will probably ask to undo this change. So I think we have to choose what makes the most sense.

@zsarnett zsarnett merged commit ca37aff into dev May 9, 2022
@zsarnett zsarnett deleted the Move-yaml-to-the-start-of-dev-tools branch May 9, 2022 13:07
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants