Pass device ID to logbook if available

[balloob]

Breaking change

Proposed change

Pass device ID to logbook if available.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New feature (thank you!)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example configuration

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue or discussion:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• There is no commented out code in this PR.
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

[bdraco]

I fixed the missing devices here home-assistant/core#72122

[balloob]

Pushed fixes.

[bdraco]

Retesting now

[bdraco]

Out of scope, but the logbook card doesn't support selecting a device or entity (only entities)

[balloob]

I want to do the device picker for logbook card in another PR because it will require making some decisions. Would you expect to pick a device, and then have it automatically select all entities too? And if we do that, should we even still show the entity picker? And should there be a toggle if the device should only show logbook entries for primary entities or also config/diagnostic?

[bdraco]

I want to do the device picker for logbook card in another PR because it will require making some decisions.

I agree 100%. Was only mentioning it for testing completeness.

Would you expect to pick a device, and then have it automatically select all entities too?

Sadly since not all entities have devices or come from config entries, I think we have to select both otherwise the user is likely missing out on a lot of entities they probably want to track.

And if we do that, should we even still show the entity picker?

Previous answer applies

And should there be a toggle if the device should only show logbook entries for primary entities or also config/diagnostic?

Previous answer applies

[bdraco]

Devices with only diagnostic entities or no entities get the full logbook.

No filter is passed to the api call

[bdraco]

There is a bug with minimal responses with the last state that is the cause of #12728 (comment)

We replace it with a full state for the frontend but we get the wrong one if we have skipped all the states at the end of the list.

Opened #12732 to get the attributes from first state instead of the last. I'm going to remove the code that replaces the last state on the backend with a full state instead of a minimal state so we don't have that complexity as it was only doing so to make the frontend happy

[bdraco]

Ok back to testing this.

[bdraco]

diff --git a/src/panels/config/devices/ha-config-device-page.ts b/src/panels/config/devices/ha-config-device-page.ts
index 3c0477573..372334048 100644
--- a/src/panels/config/devices/ha-config-device-page.ts
+++ b/src/panels/config/devices/ha-config-device-page.ts
@@ -594,8 +598,8 @@ export class HaConfigDevicePage extends LitElement {
                       <ha-logbook
                         .hass=${this.hass}
                         .time=${this._logbookTime}
-                        .entityId=${this._entityIds(entities)}
-                        .deviceId=${this._deviceIdInList(this.deviceId)}
+                        .entityIds=${this._entityIds(entities)}
+                        .deviceIds=${this._deviceIdInList(this.deviceId)}
                         virtualize
                         narrow
                         no-icon

[bdraco]

Finished testing. Looks like just the missing ss and this is GTG 👍

[bdraco]

✅ Logbook cards
✅ Logbook from left bar
✅ Areas
✅ Devices #12728 (comment)
✅ More Info

[bdraco]

This one is really so cool to see in action. 👍