Skip to content

Import all date-fns from modules#12717

Merged
balloob merged 1 commit intodevfrom
date-fns-esm
May 18, 2022
Merged

Import all date-fns from modules#12717
balloob merged 1 commit intodevfrom
date-fns-esm

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented May 17, 2022

Breaking change

Proposed change

We should only import date-fns from their module-based sub-package to be able to properly deduplicate.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@balloob balloob merged commit 82035d5 into dev May 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the date-fns-esm branch May 18, 2022 19:09
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants