Skip to content

Fix 'loading_log' string#12712

Merged
balloob merged 1 commit intohome-assistant:devfrom
RoboMagus:fix_loading_log_string
May 18, 2022
Merged

Fix 'loading_log' string#12712
balloob merged 1 commit intohome-assistant:devfrom
RoboMagus:fix_loading_log_string

Conversation

@RoboMagus
Copy link
Copy Markdown
Contributor

Proposed change

It's bugged me a while that when clicking Load full logs you are presented with Loading error log... where loading the full log is actually about retrieving more verbose data.
This change updates the string so that it properly reflects Loading full log....

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

This change will have to be propagated to all translations.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 😄

@balloob balloob merged commit 8216b52 into home-assistant:dev May 18, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 19, 2022
@RoboMagus RoboMagus deleted the fix_loading_log_string branch June 19, 2023 20:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants