Fix python to js timestamp conversions in logbook traces#12677
Merged
balloob merged 1 commit intohome-assistant:devfrom May 18, 2022
Merged
Fix python to js timestamp conversions in logbook traces#12677balloob merged 1 commit intohome-assistant:devfrom
balloob merged 1 commit intohome-assistant:devfrom
Conversation
- The websocket version needs the time converted from where python stores the decimal
Member
|
I don't think that we can do it earlier. On access is the best approach so we don't compute data that won't end up being used. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
where python stores the decimal
I didn't realize these were accessed outside the logbook model
Is there a better way to fix this? Ideally it would get converted at a sooner place but I'm not sure where that would be best to do that.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: