Skip to content

Add guard logic from PR home-assistant#12181 to input select row#12703

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
breakthestatic:input-select-guard-bad-options
May 17, 2022
Merged

Add guard logic from PR home-assistant#12181 to input select row#12703
bramkragten merged 1 commit intohome-assistant:devfrom
breakthestatic:input-select-guard-bad-options

Conversation

@breakthestatic
Copy link
Contributor

Proposed change

Add the guard logic introduced in PR #12181 to the input select row; it short-circuits the change event when the passed option doesn't exist in the list of possible options.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten bramkragten enabled auto-merge (squash) May 17, 2022 10:16
@bramkragten bramkragten merged commit dd3a3ec into home-assistant:dev May 17, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 18, 2022
@breakthestatic breakthestatic deleted the input-select-guard-bad-options branch June 14, 2023 18:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sporadic warnings in log referencing invalid input_selection options.

3 participants