Move preload_stream setting to entity settings#12730
Merged
Conversation
balloob
reviewed
May 20, 2022
| ${this._cameraPrefs | ||
| ? html` | ||
| <ha-settings-row> | ||
| <span slot="heading">Preload camera stream</span> |
balloob
reviewed
May 20, 2022
Comment on lines
+427
to
+429
| >This keeps the camera stream open in the background so it | ||
| shows quicker. Warning! This can slow down your instance | ||
| drastically.</span |
Member
There was a problem hiding this comment.
For in localize:
Suggested change
| >This keeps the camera stream open in the background so it | |
| shows quicker. Warning! This can slow down your instance | |
| drastically.</span | |
| >This keeps the camera stream open in the background so it | |
| shows quicker. Warning! This is CPU/network intensive.</span |
Contributor
There was a problem hiding this comment.
We want to move from CPU though. Hardware /Network ?
Member
There was a problem hiding this comment.
I don't understand the comments. You're saying you want it to say "This is hardware intensive"?
Member
There was a problem hiding this comment.
CPU is a bit technical in my opinion. Instead of hardware, maybe device?
balloob
previously approved these changes
May 20, 2022
zsarnett
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Entities without and unique id will lose this setting
Proposed change
Move preload stream setting from more info dialog to entity settings.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: