Skip to content

Fix enter key support for generic dialog box#12600

Merged
bramkragten merged 1 commit intohome-assistant:devfrom
steverep:dialog-box-enter-key
May 6, 2022
Merged

Fix enter key support for generic dialog box#12600
bramkragten merged 1 commit intohome-assistant:devfrom
steverep:dialog-box-enter-key

Conversation

@steverep
Copy link
Member

@steverep steverep commented May 5, 2022

Proposed change

Fix enter key support for generic dialog box by removing unnecessary handlers as described in my comment and review of #12360. The mwc-dialog component handles the key press, so all this dialog has to do is grab the current value.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

@bramkragten bramkragten merged commit cf05fba into home-assistant:dev May 6, 2022
@steverep steverep deleted the dialog-box-enter-key branch May 6, 2022 16:22
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pushing the "Enter" key on the Password Change modal closes the modal

3 participants