Skip to content

Teach logbook about additional context data#12667

Merged
balloob merged 26 commits intohome-assistant:devfrom
bdraco:logbook_additional_events_support
May 16, 2022
Merged

Teach logbook about additional context data#12667
balloob merged 26 commits intohome-assistant:devfrom
bdraco:logbook_additional_events_support

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented May 12, 2022

Proposed change

Requires home-assistant/core#71721

Screen Shot 2022-05-12 at 00 56 18

Screen Shot 2022-05-12 at 01 40 01

image

image
image

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bdraco bdraco marked this pull request as ready for review May 13, 2022 01:12
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 13, 2022

I've run though every event in the last 7 days in my logbook and they all look good and make sense now

bdraco added a commit to bdraco/home-assistant that referenced this pull request May 15, 2022
Breaking:

- The entity name is now always shown with the
  current name instead of the old name if it
  was renamed. If the entity no longer exists
  we now show the original entity_id instead
  Requires home-assistant/frontend#12667

- The name of the entity is no longer sent, and
  the current name in the state machine is now
  used

- We no longer parse attributes in python. This
  task is offloaded to the database since we only
  need it for the icon.
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
balloob
balloob previously approved these changes May 16, 2022
bdraco and others added 3 commits May 15, 2022 23:07
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented May 16, 2022

Looks good in light and dark mode 👍

@balloob balloob merged commit 01a5343 into home-assistant:dev May 16, 2022
@bdraco bdraco deleted the logbook_additional_events_support branch May 16, 2022 04:26
@kukulich
Copy link
Copy Markdown
Contributor

This is not good for translators :(

@home-assistant home-assistant locked as off-topic and limited conversation to collaborators May 16, 2022
@zsarnett
Copy link
Copy Markdown
Contributor

Can you open an issue if there needs to be changes for Translations?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants