Allow setting device_class "outlet" again through entity settings#12669
Merged
zsarnett merged 3 commits intohome-assistant:devfrom May 23, 2022
Merged
Allow setting device_class "outlet" again through entity settings#12669zsarnett merged 3 commits intohome-assistant:devfrom
device_class "outlet" again through entity settings#12669zsarnett merged 3 commits intohome-assistant:devfrom
Conversation
bdraco
reviewed
May 13, 2022
bramkragten
reviewed
May 19, 2022
Contributor
|
@spacegaier Would like to merge this before beta if you can look at the reviews. Ill merge tonight or tomorrow |
zsarnett
approved these changes
May 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
For covers and binary sensors the "Show as" dropdown allows changing the
device_classto whatever fits best. However, in the settings dialog of a switch entity the "Show as" dropdown controls the newswitch_as_xbehavior. That however means, that we lost the option to change the switchdevice_class.With this PR this option is now back.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: